MSVC: Substitute $(top_builddir) in REGRESS_OPTS.

nmisch · nmisch · commit f12976ab8393 · 2014-07-23T00:35:53.000-04:00
Commit d7cdf6e introduced a usage thereof. Back-patch to 9.0, like that commit.
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -326,9 +326,13 @@ sub fetchRegressOpts
 	if ($m =~ /^\s*REGRESS_OPTS\s*=(.*)/m)
 	{
 
-		# ignore options that use makefile variables - can't handle those
-		# ignore anything that isn't an option staring with --
-		@opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ } split(/\s+/, $1);
+		# Substitute known Makefile variables, then ignore options that retain
+		# an unhandled variable reference.  Ignore anything that isn't an
+		# option starting with "--".
+		@opts = grep {
+			s/\Q$(top_builddir)\E/\"$topdir\"/;
+			$_ !~ /\$\(/ && $_ =~ /^--/
+		} split(/\s+/, $1);
 	}
 	if ($m =~ /^\s*ENCODING\s*=\s*(\S+)/m)
 	{

Original file line number	Diff line number	Diff line change
`@@ -326,9 +326,13 @@ sub fetchRegressOpts`
`326`	`326`	`if ($m =~ /^\sREGRESS_OPTS\s=(.*)/m)`
`327`	`327`	`{`
`328`	`328`
`329`		`- # ignore options that use makefile variables - can't handle those`
`330`		`- # ignore anything that isn't an option staring with --`
`331`		`- @opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ } split(/\s+/, $1);`
	`329`	`+ # Substitute known Makefile variables, then ignore options that retain`
	`330`	`+ # an unhandled variable reference. Ignore anything that isn't an`
	`331`	`+ # option starting with "--".`
	`332`	`+ @opts = grep {`
	`333`	`+ s/\Q$(top_builddir)\E/\"$topdir\"/;`
	`334`	`+ $_ !~ /\$\(/ && $_ =~ /^--/`
	`335`	`+ } split(/\s+/, $1);`
`332`	`336`	`}`
`333`	`337`	`if ($m =~ /^\sENCODING\s=\s*(\S+)/m)`
`334`	`338`	`{`