Skip to content

Commit f256236

Browse files
alvherrealvherre
committed
Remove ALL keyword from TABLES IN SCHEMA for publication
This may be a bit too subtle, but removing that word from there makes this clause no longer a perfect parallel of the GRANT variant "ALL TABLES IN SCHEMA": indeed, for publications what we record is the schema itself, not the tables therein, which means that any tables added to the schema in the future are also published. This is completely different to what GRANT does, which is affect only the tables that exist when the command is executed. There isn't resounding support for this change, but there are a few positive votes and no opposition. Because the time to 15 RC1 is very short, let's get this out now. Backpatch to 15. Discussion: https://postgr.es/m/2729c9e2-9aac-8cda-f2f4-34f2bcc18f4e
1 parent 5f56933 commit f256236

21 files changed

+177
-180
lines changed

‎doc/src/sgml/logical-replication.sgml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ test_sub=# SELECT * FROM t3;
700700
<listitem>
701701
<para>
702702
one of the publications was created using
703-
<literal>FOR ALL TABLES IN SCHEMA</literal> and the table belongs to
703+
<literal>FOR TABLES IN SCHEMA</literal> and the table belongs to
704704
the referred schema. This clause does not allow row filters.
705705
</para>
706706
</listitem>
@@ -1530,7 +1530,7 @@ CONTEXT: processing remote data for replication origin "pg_16395" during "INSER
15301530
Moreover, if untrusted users can create tables, use only
15311531
publications that list tables explicitly. That is to say, create a
15321532
subscription <literal>FOR ALL TABLES</literal> or
1533-
<literal>FOR ALL TABLES IN SCHEMA</literal> only when superusers trust
1533+
<literal>FOR TABLES IN SCHEMA</literal> only when superusers trust
15341534
every user permitted to create a non-temp table on the publisher or the
15351535
subscriber.
15361536
</para>

‎doc/src/sgml/ref/alter_publication.sgml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ ALTER PUBLICATION <replaceable class="parameter">name</replaceable> RENAME TO <r
3131
<phrase>where <replaceable class="parameter">publication_object</replaceable> is one of:</phrase>
3232

3333
TABLE [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ] [ ( <replaceable class="parameter">column_name</replaceable> [, ... ] ) ] [ WHERE ( <replaceable class="parameter">expression</replaceable> ) ] [, ... ]
34-
ALL TABLES IN SCHEMA { <replaceable class="parameter">schema_name</replaceable> | CURRENT_SCHEMA } [, ... ]
34+
TABLES IN SCHEMA { <replaceable class="parameter">schema_name</replaceable> | CURRENT_SCHEMA } [, ... ]
3535
</synopsis>
3636
</refsynopsisdiv>
3737

@@ -71,19 +71,19 @@ ALTER PUBLICATION <replaceable class="parameter">name</replaceable> RENAME TO <r
7171
<para>
7272
You must own the publication to use <command>ALTER PUBLICATION</command>.
7373
Adding a table to a publication additionally requires owning that table.
74-
The <literal>ADD ALL TABLES IN SCHEMA</literal> and
75-
<literal>SET ALL TABLES IN SCHEMA</literal> to a publication requires the
74+
The <literal>ADD TABLES IN SCHEMA</literal> and
75+
<literal>SET TABLES IN SCHEMA</literal> to a publication requires the
7676
invoking user to be a superuser. To alter the owner, you must also be a
7777
direct or indirect member of the new owning role. The new owner must have
7878
<literal>CREATE</literal> privilege on the database. Also, the new owner
79-
of a <literal>FOR ALL TABLES</literal> or <literal>FOR ALL TABLES IN
80-
SCHEMA</literal> publication must be a superuser. However, a superuser can
79+
of a <literal>FOR ALL TABLES</literal> or <literal>FOR TABLES IN SCHEMA</literal>
80+
publication must be a superuser. However, a superuser can
8181
change the ownership of a publication regardless of these restrictions.
8282
</para>
8383

8484
<para>
8585
Adding/Setting a table that is part of schema specified in
86-
<literal>ALL TABLES IN SCHEMA</literal>, adding/setting a schema to a
86+
<literal>TABLES IN SCHEMA</literal>, adding/setting a schema to a
8787
publication that already has a table that is part of the specified schema or
8888
adding/setting a table to a publication that already has a table's schema as
8989
part of the specified schema is not supported.
@@ -200,7 +200,7 @@ ALTER PUBLICATION mypublication SET TABLE users (user_id, firstname, lastname),
200200
<structname>sales</structname> to the publication
201201
<structname>sales_publication</structname>:
202202
<programlisting>
203-
ALTER PUBLICATION sales_publication ADD ALL TABLES IN SCHEMA marketing, sales;
203+
ALTER PUBLICATION sales_publication ADD TABLES IN SCHEMA marketing, sales;
204204
</programlisting>
205205
</para>
206206

@@ -210,7 +210,7 @@ ALTER PUBLICATION sales_publication ADD ALL TABLES IN SCHEMA marketing, sales;
210210
<structname>production</structname> to the publication
211211
<structname>production_publication</structname>:
212212
<programlisting>
213-
ALTER PUBLICATION production_publication ADD TABLE users, departments, ALL TABLES IN SCHEMA production;
213+
ALTER PUBLICATION production_publication ADD TABLE users, departments, TABLES IN SCHEMA production;
214214
</programlisting></para>
215215
</refsect1>
216216

‎doc/src/sgml/ref/create_publication.sgml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
2929
<phrase>where <replaceable class="parameter">publication_object</replaceable> is one of:</phrase>
3030

3131
TABLE [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ] [ ( <replaceable class="parameter">column_name</replaceable> [, ... ] ) ] [ WHERE ( <replaceable class="parameter">expression</replaceable> ) ] [, ... ]
32-
ALL TABLES IN SCHEMA { <replaceable class="parameter">schema_name</replaceable> | CURRENT_SCHEMA } [, ... ]
32+
TABLES IN SCHEMA { <replaceable class="parameter">schema_name</replaceable> | CURRENT_SCHEMA } [, ... ]
3333
</synopsis>
3434
</refsynopsisdiv>
3535

@@ -112,7 +112,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
112112

113113
<para>
114114
Specifying a table that is part of a schema specified by
115-
<literal>FOR ALL TABLES IN SCHEMA</literal> is not supported.
115+
<literal>FOR TABLES IN SCHEMA</literal> is not supported.
116116
</para>
117117
</listitem>
118118
</varlistentry>
@@ -128,7 +128,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
128128
</varlistentry>
129129

130130
<varlistentry>
131-
<term><literal>FOR ALL TABLES IN SCHEMA</literal></term>
131+
<term><literal>FOR TABLES IN SCHEMA</literal></term>
132132
<listitem>
133133
<para>
134134
Marks the publication as one that replicates changes for all tables in
@@ -224,7 +224,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
224224

225225
<para>
226226
If <literal>FOR TABLE</literal>, <literal>FOR ALL TABLES</literal> or
227-
<literal>FOR ALL TABLES IN SCHEMA</literal> are not specified, then the
227+
<literal>FOR TABLES IN SCHEMA</literal> are not specified, then the
228228
publication starts out with an empty set of tables. That is useful if
229229
tables or schemas are to be added later.
230230
</para>
@@ -243,7 +243,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
243243
<para>
244244
To add a table to a publication, the invoking user must have ownership
245245
rights on the table. The <command>FOR ALL TABLES</command> and
246-
<command>FOR ALL TABLES IN SCHEMA</command> clauses require the invoking
246+
<command>FOR TABLES IN SCHEMA</command> clauses require the invoking
247247
user to be a superuser.
248248
</para>
249249

@@ -354,7 +354,7 @@ CREATE PUBLICATION insert_only FOR TABLE mydata
354354
all changes for all the tables present in the schema
355355
<structname>production</structname>:
356356
<programlisting>
357-
CREATE PUBLICATION production_publication FOR TABLE users, departments, ALL TABLES IN SCHEMA production;
357+
CREATE PUBLICATION production_publication FOR TABLE users, departments, TABLES IN SCHEMA production;
358358
</programlisting>
359359
</para>
360360

@@ -363,7 +363,7 @@ CREATE PUBLICATION production_publication FOR TABLE users, departments, ALL TABL
363363
the schemas <structname>marketing</structname> and
364364
<structname>sales</structname>:
365365
<programlisting>
366-
CREATE PUBLICATION sales_publication FOR ALL TABLES IN SCHEMA marketing, sales;
366+
CREATE PUBLICATION sales_publication FOR TABLES IN SCHEMA marketing, sales;
367367
</programlisting></para>
368368

369369
<para>

‎doc/src/sgml/ref/create_subscription.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
347347
publications has no <literal>WHERE</literal> clause (referring to that
348348
publish operation) or the publication is declared as
349349
<literal>FOR ALL TABLES</literal> or
350-
<literal>FOR ALL TABLES IN SCHEMA</literal>, rows are always published
350+
<literal>FOR TABLES IN SCHEMA</literal>, rows are always published
351351
regardless of the definition of the other expressions.
352352
If the subscriber is a <productname>PostgreSQL</productname> version before
353353
15 then any row filtering is ignored during the initial data synchronization

‎doc/src/sgml/system-views.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2090,7 +2090,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
20902090
tables they contain. Unlike the underlying catalog
20912091
<link linkend="catalog-pg-publication-rel"><structname>pg_publication_rel</structname></link>,
20922092
this view expands publications defined as <literal>FOR ALL TABLES</literal>
2093-
and <literal>FOR ALL TABLES IN SCHEMA</literal>, so for such publications
2093+
and <literal>FOR TABLES IN SCHEMA</literal>, so for such publications
20942094
there will be a row for each eligible table.
20952095
</para>
20962096

‎src/backend/catalog/pg_publication.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,7 @@ GetAllTablesPublicationRelations(bool pubviaroot)
837837
/*
838838
* Gets the list of schema oids for a publication.
839839
*
840-
* This should only be used FOR ALL TABLES IN SCHEMA publications.
840+
* This should only be used FOR TABLES IN SCHEMA publications.
841841
*/
842842
List *
843843
GetPublicationSchemas(Oid pubid)
@@ -957,7 +957,7 @@ GetSchemaPublicationRelations(Oid schemaid, PublicationPartOpt pub_partopt)
957957
}
958958

959959
/*
960-
* Gets the list of all relations published by FOR ALL TABLES IN SCHEMA
960+
* Gets the list of all relations published by FOR TABLES IN SCHEMA
961961
* publication.
962962
*/
963963
List *

‎src/backend/commands/publicationcmds.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -847,11 +847,11 @@ CreatePublication(ParseState *pstate, CreatePublicationStmt *stmt)
847847
ObjectsInPublicationToOids(stmt->pubobjects, pstate, &relations,
848848
&schemaidlist);
849849

850-
/* FOR ALL TABLES IN SCHEMA requires superuser */
851-
if (list_length(schemaidlist) > 0 && !superuser())
850+
/* FOR TABLES IN SCHEMA requires superuser */
851+
if (schemaidlist != NIL && !superuser())
852852
ereport(ERROR,
853853
errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
854-
errmsg("must be superuser to create FOR ALL TABLES IN SCHEMA publication"));
854+
errmsg("must be superuser to create FOR TABLES IN SCHEMA publication"));
855855

856856
if (list_length(relations) > 0)
857857
{
@@ -1979,7 +1979,7 @@ AlterPublicationOwner_internal(Relation rel, HeapTuple tup, Oid newOwnerId)
19791979
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
19801980
errmsg("permission denied to change owner of publication \"%s\"",
19811981
NameStr(form->pubname)),
1982-
errhint("The owner of a FOR ALL TABLES IN SCHEMA publication must be a superuser.")));
1982+
errhint("The owner of a FOR TABLES IN SCHEMA publication must be a superuser.")));
19831983
}
19841984

19851985
form->pubowner = newOwnerId;

‎src/backend/parser/gram.y

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10303,7 +10303,7 @@ AlterOwnerStmt: ALTER AGGREGATE aggregate_with_argtypes OWNER TO RoleSpec
1030310303
* pub_obj is one of:
1030410304
*
1030510305
* TABLE table [, ...]
10306-
* ALL TABLES IN SCHEMA schema [, ...]
10306+
* TABLES IN SCHEMA schema [, ...]
1030710307
*
1030810308
*****************************************************************************/
1030910309

@@ -10338,7 +10338,7 @@ CreatePublicationStmt:
1033810338
;
1033910339

1034010340
/*
10341-
* FOR TABLE and FOR ALL TABLES IN SCHEMA specifications
10341+
* FOR TABLE and FOR TABLES IN SCHEMA specifications
1034210342
*
1034310343
* This rule parses publication objects with and without keyword prefixes.
1034410344
*
@@ -10360,18 +10360,18 @@ PublicationObjSpec:
1036010360
$$->pubtable->columns = $3;
1036110361
$$->pubtable->whereClause = $4;
1036210362
}
10363-
| ALL TABLES IN_P SCHEMA ColId
10363+
| TABLES IN_P SCHEMA ColId
1036410364
{
1036510365
$$ = makeNode(PublicationObjSpec);
1036610366
$$->pubobjtype = PUBLICATIONOBJ_TABLES_IN_SCHEMA;
10367-
$$->name = $5;
10368-
$$->location = @5;
10367+
$$->name = $4;
10368+
$$->location = @4;
1036910369
}
10370-
| ALL TABLES IN_P SCHEMA CURRENT_SCHEMA
10370+
| TABLES IN_P SCHEMA CURRENT_SCHEMA
1037110371
{
1037210372
$$ = makeNode(PublicationObjSpec);
1037310373
$$->pubobjtype = PUBLICATIONOBJ_TABLES_IN_CUR_SCHEMA;
10374-
$$->location = @5;
10374+
$$->location = @4;
1037510375
}
1037610376
| ColId opt_column_list OptWhereClause
1037710377
{
@@ -10447,7 +10447,7 @@ pub_obj_list: PublicationObjSpec
1044710447
* pub_obj is one of:
1044810448
*
1044910449
* TABLE table_name [, ...]
10450-
* ALL TABLES IN SCHEMA schema_name [, ...]
10450+
* TABLES IN SCHEMA schema_name [, ...]
1045110451
*
1045210452
*****************************************************************************/
1045310453

@@ -18431,7 +18431,7 @@ preprocess_pubobj_list(List *pubobjspec_list, core_yyscan_t yyscanner)
1843118431
ereport(ERROR,
1843218432
errcode(ERRCODE_SYNTAX_ERROR),
1843318433
errmsg("invalid publication object list"),
18434-
errdetail("One of TABLE or ALL TABLES IN SCHEMA must be specified before a standalone table or schema name."),
18434+
errdetail("One of TABLE or TABLES IN SCHEMA must be specified before a standalone table or schema name."),
1843518435
parser_errposition(pubobj->location));
1843618436

1843718437
foreach(cell, pubobjspec_list)

‎src/backend/replication/pgoutput/pgoutput.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -995,8 +995,7 @@ pgoutput_column_list_init(PGOutputData *data, List *publications,
995995
* need to check all the given publication-table mappings and report an
996996
* error if any publications have a different column list.
997997
*
998-
* FOR ALL TABLES and FOR ALL TABLES IN SCHEMA implies "don't use column
999-
* list".
998+
* FOR ALL TABLES and FOR TABLES IN SCHEMA imply "don't use column list".
1000999
*/
10011000
foreach(lc, publications)
10021001
{

‎src/bin/pg_dump/pg_dump.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4318,7 +4318,7 @@ dumpPublicationNamespace(Archive *fout, const PublicationSchemaInfo *pubsinfo)
43184318
query = createPQExpBuffer();
43194319

43204320
appendPQExpBuffer(query, "ALTER PUBLICATION %s ", fmtId(pubinfo->dobj.name));
4321-
appendPQExpBuffer(query, "ADD ALL TABLES IN SCHEMA %s;\n", fmtId(schemainfo->dobj.name));
4321+
appendPQExpBuffer(query, "ADD TABLES IN SCHEMA %s;\n", fmtId(schemainfo->dobj.name));
43224322

43234323
/*
43244324
* There is no point in creating drop query as the drop is done by schema

‎src/bin/pg_dump/t/002_pg_dump.pl

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2522,23 +2522,22 @@
25222522
unlike => { exclude_dump_test_schema => 1, },
25232523
},
25242524
2525-
'ALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA dump_test' => {
2525+
'ALTER PUBLICATION pub3 ADD TABLES IN SCHEMA dump_test' => {
25262526
create_order => 51,
25272527
create_sql =>
2528-
'ALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA dump_test;',
2528+
'ALTER PUBLICATION pub3 ADD TABLES IN SCHEMA dump_test;',
25292529
regexp => qr/^
2530-
\QALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA dump_test;\E
2530+
\QALTER PUBLICATION pub3 ADD TABLES IN SCHEMA dump_test;\E
25312531
/xm,
25322532
like => { %full_runs, section_post_data => 1, },
25332533
unlike => { exclude_dump_test_schema => 1, },
25342534
},
25352535
2536-
'ALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA public' => {
2536+
'ALTER PUBLICATION pub3 ADD TABLES IN SCHEMA public' => {
25372537
create_order => 52,
2538-
create_sql =>
2539-
'ALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA public;',
2540-
regexp => qr/^
2541-
\QALTER PUBLICATION pub3 ADD ALL TABLES IN SCHEMA public;\E
2538+
create_sql => 'ALTER PUBLICATION pub3 ADD TABLES IN SCHEMA public;',
2539+
regexp => qr/^
2540+
\QALTER PUBLICATION pub3 ADD TABLES IN SCHEMA public;\E
25422541
/xm,
25432542
like => { %full_runs, section_post_data => 1, },
25442543
},

‎src/bin/psql/tab-complete.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1820,7 +1820,7 @@ psql_completion(const char *text, int start, int end)
18201820
COMPLETE_WITH("ADD", "DROP", "OWNER TO", "RENAME TO", "SET");
18211821
/* ALTER PUBLICATION <name> ADD */
18221822
else if (Matches("ALTER", "PUBLICATION", MatchAny, "ADD"))
1823-
COMPLETE_WITH("ALL TABLES IN SCHEMA", "TABLE");
1823+
COMPLETE_WITH("TABLES IN SCHEMA", "TABLE");
18241824
else if (Matches("ALTER", "PUBLICATION", MatchAny, "ADD|SET", "TABLE") ||
18251825
(HeadMatches("ALTER", "PUBLICATION", MatchAny, "ADD|SET", "TABLE") &&
18261826
ends_with(prev_wd, ',')))
@@ -1844,10 +1844,10 @@ psql_completion(const char *text, int start, int end)
18441844
COMPLETE_WITH(",");
18451845
/* ALTER PUBLICATION <name> DROP */
18461846
else if (Matches("ALTER", "PUBLICATION", MatchAny, "DROP"))
1847-
COMPLETE_WITH("ALL TABLES IN SCHEMA", "TABLE");
1847+
COMPLETE_WITH("TABLES IN SCHEMA", "TABLE");
18481848
/* ALTER PUBLICATION <name> SET */
18491849
else if (Matches("ALTER", "PUBLICATION", MatchAny, "SET"))
1850-
COMPLETE_WITH("(", "ALL TABLES IN SCHEMA", "TABLE");
1850+
COMPLETE_WITH("(", "TABLES IN SCHEMA", "TABLE");
18511851
else if (Matches("ALTER", "PUBLICATION", MatchAny, "ADD|DROP|SET", "ALL", "TABLES", "IN", "SCHEMA"))
18521852
COMPLETE_WITH_QUERY_PLUS(Query_for_list_of_schemas
18531853
" AND nspname NOT LIKE E'pg\\\\_%%'",
@@ -2975,9 +2975,9 @@ psql_completion(const char *text, int start, int end)
29752975

29762976
/* CREATE PUBLICATION */
29772977
else if (Matches("CREATE", "PUBLICATION", MatchAny))
2978-
COMPLETE_WITH("FOR TABLE", "FOR ALL TABLES", "FOR ALL TABLES IN SCHEMA", "WITH (");
2978+
COMPLETE_WITH("FOR TABLE", "FOR ALL TABLES", "FOR TABLES IN SCHEMA", "WITH (");
29792979
else if (Matches("CREATE", "PUBLICATION", MatchAny, "FOR"))
2980-
COMPLETE_WITH("TABLE", "ALL TABLES", "ALL TABLES IN SCHEMA");
2980+
COMPLETE_WITH("TABLE", "ALL TABLES", "TABLES IN SCHEMA");
29812981
else if (Matches("CREATE", "PUBLICATION", MatchAny, "FOR", "ALL"))
29822982
COMPLETE_WITH("TABLES", "TABLES IN SCHEMA");
29832983
else if (Matches("CREATE", "PUBLICATION", MatchAny, "FOR", "ALL", "TABLES"))
@@ -3000,8 +3000,7 @@ psql_completion(const char *text, int start, int end)
30003000
COMPLETE_WITH(" WITH (");
30013001

30023002
/*
3003-
* Complete "CREATE PUBLICATION <name> FOR ALL TABLES IN SCHEMA <schema>,
3004-
* ..."
3003+
* Complete "CREATE PUBLICATION <name> FOR TABLES IN SCHEMA <schema>, ..."
30053004
*/
30063005
else if (Matches("CREATE", "PUBLICATION", MatchAny, "FOR", "ALL", "TABLES", "IN", "SCHEMA"))
30073006
COMPLETE_WITH_QUERY_PLUS(Query_for_list_of_schemas
@@ -3821,7 +3820,7 @@ psql_completion(const char *text, int start, int end)
38213820
"ALL PROCEDURES IN SCHEMA",
38223821
"ALL ROUTINES IN SCHEMA",
38233822
"ALL SEQUENCES IN SCHEMA",
3824-
"ALL TABLES IN SCHEMA",
3823+
"TABLES IN SCHEMA",
38253824
"DATABASE",
38263825
"DOMAIN",
38273826
"FOREIGN DATA WRAPPER",

‎src/test/regress/expected/alter_table.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4589,7 +4589,7 @@ create schema alter1;
45894589
create schema alter2;
45904590
create table alter1.t1 (a int);
45914591
set client_min_messages = 'ERROR';
4592-
create publication pub1 for table alter1.t1, all tables in schema alter2;
4592+
create publication pub1 for table alter1.t1, tables in schema alter2;
45934593
reset client_min_messages;
45944594
alter table alter1.t1 set schema alter2; -- should fail
45954595
ERROR: cannot move table "t1" to schema "alter2"

‎src/test/regress/expected/object_address.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ CREATE TRANSFORM FOR int LANGUAGE SQL (
4545
-- suppress warning that depends on wal_level
4646
SET client_min_messages = 'ERROR';
4747
CREATE PUBLICATION addr_pub FOR TABLE addr_nsp.gentable;
48-
CREATE PUBLICATION addr_pub_schema FOR ALL TABLES IN SCHEMA addr_nsp;
48+
CREATE PUBLICATION addr_pub_schema FOR TABLES IN SCHEMA addr_nsp;
4949
RESET client_min_messages;
5050
CREATE SUBSCRIPTION regress_addr_sub CONNECTION '' PUBLICATION bar WITH (connect = false, slot_name = NONE);
5151
WARNING: tables were not subscribed, you will have to run ALTER SUBSCRIPTION ... REFRESH PUBLICATION to subscribe the tables

0 commit comments

Comments
 (0)