Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

petere · petere · commit f4eabaf3e0f8 · 2018-12-22T07:21:40.000+01:00
This has never been correct since this code was introduced.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -2942,7 +2942,7 @@ create_xlog_or_symlink(void)
 			exit_nicely();
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit_nicely();
 #endif
 	}
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2588,7 +2588,7 @@ main(int argc, char **argv)
 			disconnect_and_exit(1);
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		disconnect_and_exit(1);
 #endif
 		free(linkloc);

Original file line number	Diff line number	Diff line change
`@@ -2942,7 +2942,7 @@ create_xlog_or_symlink(void)`
`2942`	`2942`	`exit_nicely();`
`2943`	`2943`	`}`
`2944`	`2944`	`#else`
`2945`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform"));`
	`2945`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2946`	`2946`	`exit_nicely();`
`2947`	`2947`	`#endif`
`2948`	`2948`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2588,7 +2588,7 @@ main(int argc, char **argv)`
`2588`	`2588`	`disconnect_and_exit(1);`
`2589`	`2589`	`}`
`2590`	`2590`	`#else`
`2591`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));`
	`2591`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2592`	`2592`	`disconnect_and_exit(1);`
`2593`	`2593`	`#endif`
`2594`	`2594`	`free(linkloc);`