This patch fixes the well-known but unfixed bug that fetchone() always returns

bmomjian · bmomjian · commit f7eedfdff248 · 2001-08-16T15:21:16.000Z
the first result in the DB-API compliant wrapper. It turned out that the bug
was way down in the C code.

Gerhard Häring
diff --git a/src/interfaces/python/pgmodule.c b/src/interfaces/python/pgmodule.c
@@ -548,13 +548,13 @@ pgsource_fetch(pgsourceobject * self, PyObject * args)
 
 		for (j = 0; j < self->num_fields; j++)
 		{
-			if (PQgetisnull(self->last_result, i, j))
+			if (PQgetisnull(self->last_result, self->current_row, j))
 			{
 				Py_INCREF(Py_None);
 				str = Py_None;
 			}
 			else
-				str = PyString_FromString(PQgetvalue(self->last_result, i, j));
+				str = PyString_FromString(PQgetvalue(self->last_result, self->current_row, j));
 
 			PyTuple_SET_ITEM(rowtuple, j, str);
 		}

Original file line number	Diff line number	Diff line change
`@@ -548,13 +548,13 @@ pgsource_fetch(pgsourceobject * self, PyObject * args)`
`548`	`548`
`549`	`549`	`for (j = 0; j < self->num_fields; j++)`
`550`	`550`	`{`
`551`		`- if (PQgetisnull(self->last_result, i, j))`
	`551`	`+ if (PQgetisnull(self->last_result, self->current_row, j))`
`552`	`552`	`{`
`553`	`553`	`Py_INCREF(Py_None);`
`554`	`554`	`str = Py_None;`
`555`	`555`	`}`
`556`	`556`	`else`
`557`		`- str = PyString_FromString(PQgetvalue(self->last_result, i, j));`
	`557`	`+ str = PyString_FromString(PQgetvalue(self->last_result, self->current_row, j));`
`558`	`558`
`559`	`559`	`PyTuple_SET_ITEM(rowtuple, j, str);`
`560`	`560`	`}`