From: CNT systemen BV <cntsys@cistron.nl>

scrappy · scrappy · commit fb269b46752b · 1997-09-28T10:05:15.000Z
I've found a problem in the Postgresql jdbc driver.
"ReceiveInteger" shifts a received byte right instead of left.
This means that only the least significant byte is read into the int.

Reviewed by: Peter T Mount &lt;patches@maidast.demon.co.uk&gt;
diff --git a/src/interfaces/jdbc/postgresql/PG_Stream.java b/src/interfaces/jdbc/postgresql/PG_Stream.java
@@ -156,7 +156,7 @@ public int ReceiveInteger(int siz) throws SQLException
 	    
 	    if (b < 0)
 	      throw new IOException("EOF");
-	    n = n | (b >> (8 * i)) ;
+	    n = n | (b << (8 * i)) ;
 	  }
       } catch (IOException e) {
 	throw new SQLException("Error reading from backend: " + e.toString());

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ public int ReceiveInteger(int siz) throws SQLException`
`156`	`156`
`157`	`157`	`if (b < 0)`
`158`	`158`	`throw new IOException("EOF");`
`159`		`- n = n \| (b >> (8 * i)) ;`
	`159`	`+ n = n \| (b << (8 * i)) ;`
`160`	`160`	`}`
`161`	`161`	`} catch (IOException e) {`
`162`	`162`	`throw new SQLException("Error reading from backend: " + e.toString());`