Skip to content

Commit fb9042f

Browse files
committed
Reduce recursion depth in recently-added regression test.
Some buildfarm members fail the test with the original depth of 10 levels, apparently because they are running at the minimum max_stack_depth setting of 100kB and using ~ 10k per recursion level. While it might be interesting to try to figure out why they're eating so much stack, it isn't likely that any fix for that would be back-patchable. So just change the test to recurse only 5 levels. The extra levels don't prove anything correctness-wise anyway.
1 parent 3f36070 commit fb9042f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/test/regress/expected/plpgsql.out

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3967,8 +3967,8 @@ DROP FUNCTION nonsimple_expr_test();
39673967
create function recurse(float8) returns float8 as
39683968
$$
39693969
begin
3970-
if ($1 < 10) then
3971-
return sql_recurse($1 + 1);
3970+
if ($1 > 0) then
3971+
return sql_recurse($1 - 1);
39723972
else
39733973
return $1;
39743974
end if;
@@ -3977,10 +3977,10 @@ $$ language plpgsql;
39773977
-- "limit" is to prevent this from being inlined
39783978
create function sql_recurse(float8) returns float8 as
39793979
$$ select recurse($1) limit 1; $$ language sql;
3980-
select recurse(0);
3980+
select recurse(5);
39813981
recurse
39823982
---------
3983-
10
3983+
0
39843984
(1 row)
39853985

39863986
create function error1(text) returns text language sql as

src/test/regress/sql/plpgsql.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3174,8 +3174,8 @@ DROP FUNCTION nonsimple_expr_test();
31743174
create function recurse(float8) returns float8 as
31753175
$$
31763176
begin
3177-
if ($1 < 10) then
3178-
return sql_recurse($1 + 1);
3177+
if ($1 > 0) then
3178+
return sql_recurse($1 - 1);
31793179
else
31803180
return $1;
31813181
end if;
@@ -3186,7 +3186,7 @@ $$ language plpgsql;
31863186
create function sql_recurse(float8) returns float8 as
31873187
$$ select recurse($1) limit 1; $$ language sql;
31883188

3189-
select recurse(0);
3189+
select recurse(5);
31903190

31913191
create function error1(text) returns text language sql as
31923192
$$ SELECT relname::text FROM pg_class c WHERE c.oid = $1::regclass $$;

0 commit comments

Comments
 (0)