Flush logical mapping files with fd opened for read/write at checkpoint

michaelpq · michaelpq · commit fbfc835b463a · 2019-10-09T13:31:22.000+09:00
The file descriptor was opened with read-only to fsync a regular file, which would cause EBADFD errors on some platforms. This is similar to the recent fix done by a586cc4 (which was broken by me with 82a5649), except that I noticed this issue while monitoring the backend code for similar mistakes. Backpatch to 9.4, as this has been introduced since logical decoding exists as of b89e151. Author: Michael Paquier Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20191006045548.GA14532@paquier.xyz Backpatch-through: 9.4
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
@@ -1279,7 +1279,8 @@ CheckPointLogicalRewriteHeap(void)
 		}
 		else
 		{
-			int			fd = OpenTransientFile(path, O_RDONLY | PG_BINARY, 0);
+			/* on some operating systems fsyncing a file requires O_RDWR */
+			int			fd = OpenTransientFile(path, O_RDWR | PG_BINARY, 0);
 
 			/*
 			 * The file cannot vanish due to concurrency since this function

Original file line number	Diff line number	Diff line change
`@@ -1279,7 +1279,8 @@ CheckPointLogicalRewriteHeap(void)`
`1279`	`1279`	`}`
`1280`	`1280`	`else`
`1281`	`1281`	`{`
`1282`		`- int fd = OpenTransientFile(path, O_RDONLY \| PG_BINARY, 0);`
	`1282`	`+ /* on some operating systems fsyncing a file requires O_RDWR */`
	`1283`	`+ int fd = OpenTransientFile(path, O_RDWR \| PG_BINARY, 0);`
`1283`	`1284`
`1284`	`1285`	`/*`
`1285`	`1286`	`* The file cannot vanish due to concurrency since this function`