Backpatch tuplesort.c assertion.

petergeoghegan · petergeoghegan · commit fdbb97939b55 · 2020-07-29T16:00:52.000-07:00
Backpatch an assertion (that was originally added to Postgres 12 by commit dd299df) that seems broadly useful. The assertion can detect violations of the HOT invariant (i.e. no two index tuples can point to the same heap TID) when CREATE INDEX somehow incorrectly allows that to take place. For example, a IndexBuildHeapScan/heapam_index_build_range_scan bug might result in two tuples that both point to the same heap TID. If these two tuples also happen to be duplicates, the assertion will fail. Discussion: https://postgr.es/m/CAH2-WzmBxu4o=pMsniur+bwHqCGCmV_AOLkuK6BuU7ngA6evqw@mail.gmail.com Backpatch: 9.5-11 only
diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
@@ -4173,6 +4173,9 @@ comparetup_index_btree(const SortTuple *a, const SortTuple *b,
 			return (pos1 < pos2) ? -1 : 1;
 	}
 
+	/* ItemPointer values should never be equal */
+	Assert(false);
+
 	return 0;
 }
 
@@ -4225,6 +4228,9 @@ comparetup_index_hash(const SortTuple *a, const SortTuple *b,
 			return (pos1 < pos2) ? -1 : 1;
 	}
 
+	/* ItemPointer values should never be equal */
+	Assert(false);
+
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4173,6 +4173,9 @@ comparetup_index_btree(const SortTuple a, const SortTuple b,`
`4173`	`4173`	`return (pos1 < pos2) ? -1 : 1;`
`4174`	`4174`	`}`
`4175`	`4175`
	`4176`	`+ /* ItemPointer values should never be equal */`
	`4177`	`+ Assert(false);`
	`4178`	`+`
`4176`	`4179`	`return 0;`
`4177`	`4180`	`}`
`4178`	`4181`
`@@ -4225,6 +4228,9 @@ comparetup_index_hash(const SortTuple a, const SortTuple b,`
`4225`	`4228`	`return (pos1 < pos2) ? -1 : 1;`
`4226`	`4229`	`}`
`4227`	`4230`
	`4231`	`+ /* ItemPointer values should never be equal */`
	`4232`	`+ Assert(false);`
	`4233`	`+`
`4228`	`4234`	`return 0;`
`4229`	`4235`	`}`
`4230`	`4236`