Fix old bug in _hash_first() for scan without keys:

vadim4o · vadim4o · commit fe91ceb62b10 · 1997-04-30T06:31:16.000Z
if 1st bucket chain is empty then need to continue scan in the rest buckets.
diff --git a/src/backend/access/hash/hashsearch.c b/src/backend/access/hash/hashsearch.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/access/hash/hashsearch.c,v 1.8 1996/11/21 06:06:52 vadim Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/access/hash/hashsearch.c,v 1.9 1997/04/30 06:31:16 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -221,7 +221,13 @@ _hash_first(IndexScanDesc scan, ScanDirection dir)
 	} else {
 	    ItemPointerSetInvalid(current);
 	    so->hashso_curbuf = InvalidBuffer;
-	    return ((RetrieveIndexResult) NULL);
+	    /* 
+	     * If there is no scankeys, all tuples will satisfy 
+	     * the scan - so we continue in _hash_step to get 
+	     * tuples from all buckets.	- vadim 04/29/97
+	     */
+	    if ( scan->numberOfKeys >= 1 )
+	    	return ((RetrieveIndexResult) NULL);
 	}
     }
     if (ScanDirectionIsBackward(dir)) {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/access/hash/hashsearch.c,v 1.8 1996/11/21 06:06:52 vadim Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/access/hash/hashsearch.c,v 1.9 1997/04/30 06:31:16 vadim Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -221,7 +221,13 @@ _hash_first(IndexScanDesc scan, ScanDirection dir)`
`221`	`221`	`} else {`
`222`	`222`	`ItemPointerSetInvalid(current);`
`223`	`223`	`so->hashso_curbuf = InvalidBuffer;`
`224`		`- return ((RetrieveIndexResult) NULL);`
	`224`	`+ /*`
	`225`	`+ * If there is no scankeys, all tuples will satisfy`
	`226`	`+ * the scan - so we continue in _hash_step to get`
	`227`	`+ * tuples from all buckets. - vadim 04/29/97`
	`228`	`+ */`
	`229`	`+ if ( scan->numberOfKeys >= 1 )`
	`230`	`+ return ((RetrieveIndexResult) NULL);`
`225`	`231`	`}`
`226`	`232`	`}`
`227`	`233`	`if (ScanDirectionIsBackward(dir)) {`