Don't pass NULL to fprintf, if a bogus connection string is given to pg_dump.

hlinnaka · hlinnaka · commit feae7c3d2bed · 2013-02-20T16:34:32.000+02:00
Back-patch to all supported branches.
diff --git a/src/bin/pg_dump/pg_backup_db.c b/src/bin/pg_dump/pg_backup_db.c
@@ -305,7 +305,8 @@ ConnectDatabase(Archive *AHX,
 	/* check to see that the backend connection was successfully made */
 	if (PQstatus(AH->connection) == CONNECTION_BAD)
 		die_horribly(AH, modulename, "connection to database \"%s\" failed: %s",
-					 PQdb(AH->connection), PQerrorMessage(AH->connection));
+					 PQdb(AH->connection) ? PQdb(AH->connection) : "",
+					 PQerrorMessage(AH->connection));
 
 	/* check for version mismatch */
 	_check_database_version(AH);
