Fix likely cause of rare ALTER TABLE ADD FOREIGN KEY failures ---

tglsfdc · tglsfdc · commit feb202193dd9 · 2002-09-12T21:16:42.000Z
don't assume relname field of a relcache entry will stay valid across
lots of operations.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.40 2002/09/06 00:01:53 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.41 2002/09/12 21:16:42 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2920,7 +2920,7 @@ createForeignKeyTriggers(Relation rel, FkConstraint *fkconstraint,
 	 * unfortunately).
 	 */
 	myRel = makeRangeVar(get_namespace_name(RelationGetNamespace(rel)),
-						 RelationGetRelationName(rel));
+						 pstrdup(RelationGetRelationName(rel)));
 
 	/*
 	 * Preset objectAddress fields

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.40 2002/09/06 00:01:53 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.41 2002/09/12 21:16:42 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -2920,7 +2920,7 @@ createForeignKeyTriggers(Relation rel, FkConstraint *fkconstraint,`
`2920`	`2920`	`* unfortunately).`
`2921`	`2921`	`*/`
`2922`	`2922`	`myRel = makeRangeVar(get_namespace_name(RelationGetNamespace(rel)),`
`2923`		`- RelationGetRelationName(rel));`
	`2923`	`+ pstrdup(RelationGetRelationName(rel)));`
`2924`	`2924`
`2925`	`2925`	`/*`
`2926`	`2926`	`* Preset objectAddress fields`