More clearly describe why PQinSend returns false for non-threaded libpq.

bmomjian · bmomjian · commit feed7cf1c148 · 2004-02-10T15:21:24.000Z
diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.36 2004/01/09 02:17:15 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.37 2004/02/10 15:21:24 momjian Exp $
  *
  * NOTES
  *	  The client *requires* a valid server certificate.  Since
@@ -1122,6 +1122,11 @@ PQinSend(void)
 	return (pthread_getspecific(thread_in_send) /* has it been set? */ &&
 			*(char *)pthread_getspecific(thread_in_send) == 't') ? true : false;
 #else
-	return false;	/* No threading, so we can't be in send() */
+	/*
+	 *	No threading: our code ignores SIGPIPE around send().
+	 *	Therefore, we can't be in send() if we are checking
+	 *	from a SIGPIPE signal handler.
+	 */
+	return false;	
 #endif
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.36 2004/01/09 02:17:15 momjian Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.37 2004/02/10 15:21:24 momjian Exp $`
`15`	`15`	`*`
`16`	`16`	`* NOTES`
`17`	`17`	`* The client requires a valid server certificate. Since`
`@@ -1122,6 +1122,11 @@ PQinSend(void)`
`1122`	`1122`	`return (pthread_getspecific(thread_in_send) /* has it been set? */ &&`
`1123`	`1123`	`(char )pthread_getspecific(thread_in_send) == 't') ? true : false;`
`1124`	`1124`	`#else`
`1125`		`- return false; /* No threading, so we can't be in send() */`
	`1125`	`+ /*`
	`1126`	`+ * No threading: our code ignores SIGPIPE around send().`
	`1127`	`+ * Therefore, we can't be in send() if we are checking`
	`1128`	`+ * from a SIGPIPE signal handler.`
	`1129`	`+ */`
	`1130`	`+ return false;`
`1126`	`1131`	`#endif`
`1127`	`1132`	`}`