pg_dumpall: Allow --no-role-passwords and --binary-upgrade together

petere · petere · commit ff46f2a05345 · 2017-04-13T21:23:34.000-04:00
This was introduced as part of the patch to add --no-role-passwords, but
while it's an unusual combination, there is no actual reason to prevent
it.
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -356,15 +356,6 @@ main(int argc, char *argv[])
 		exit_nicely(1);
 	}
 
-	if (no_role_passwords && binary_upgrade)
-	{
-		fprintf(stderr, _("%s: options --no-role-passwords and --binary-upgrade cannot be used together\n"),
-				progname);
-		fprintf(stderr, _("Try \"%s --help\" for more information.\n"),
-				progname);
-		exit_nicely(1);
-	}
-
 	/*
 	 * If password values are not required in the dump, switch to
 	 * using pg_roles which is equally useful, just more likely
