Fix compiler warnings about appendStringInfoVA and appendStringInfoVA_s.

schmiddy · schmiddy · commit 0942141245a4 · 2012-10-18T20:32:18.000-07:00
gcc was correctly complaining that these functions should be declared with the `printf` format attribute. Addresses Issue #14.
diff --git a/bin/pgut/pgut.h b/bin/pgut/pgut.h
@@ -149,7 +149,8 @@ extern void CHECK_FOR_INTERRUPTS(void);
 #define appendStringInfoChar	appendPQExpBufferChar
 #define appendBinaryStringInfo	appendBinaryPQExpBuffer
 
-extern bool appendStringInfoVA(StringInfo str, const char *fmt, va_list args);
+extern bool appendStringInfoVA(StringInfo str, const char *fmt, va_list args)
+__attribute__((format(printf, 2, 0)));
 extern int appendStringInfoFile(StringInfo str, FILE *fp);
 extern int appendStringInfoFd(StringInfo str, int fd);
 
diff --git a/lib/pgut/pgut-spi.c b/lib/pgut/pgut-spi.c
@@ -13,6 +13,10 @@
 #define EXEC_FAILED(ret, expected) \
 	(((expected) > 0 && (ret) != (expected)) || (ret) < 0)
 
+static void
+appendStringInfoVA_s(StringInfo str, const char *fmt, va_list args)
+__attribute__((format(printf, 2, 0)));
+
 static void
 termStringInfo(StringInfo str)
 {
