Fix small oversight in recent patch to add more CREATE-FUNCTION-time

tglsfdc · tglsfdc · commit 203015ebddee · 2005-10-13T15:34:19.000Z
syntax checking to plpgsql: check_sql_expr() wasn't being called by
make_select_stmt(), so that there was no SQL syntax check for SELECT
statements.
diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y
@@ -4,7 +4,7 @@
  *						  procedural language
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.81 2005/09/14 13:46:47 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.82 2005/10/13 15:34:19 tgl Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -1986,6 +1986,8 @@ make_select_stmt(void)
 		expr->params[nparams] = params[nparams];
 	plpgsql_dstring_free(&ds);
 
+	check_sql_expr(expr->query);
+
 	if (have_into)
 	{
 		PLpgSQL_stmt_select *select;

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`* procedural language`
`5`	`5`	`*`
`6`	`6`	`* IDENTIFICATION`
`7`		`- * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.81 2005/09/14 13:46:47 tgl Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.82 2005/10/13 15:34:19 tgl Exp $`
`8`	`8`	`*`
`9`	`9`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`10`	`10`	`*`
`@@ -1986,6 +1986,8 @@ make_select_stmt(void)`
`1986`	`1986`	`expr->params[nparams] = params[nparams];`
`1987`	`1987`	`plpgsql_dstring_free(&ds);`
`1988`	`1988`
	`1989`	`+ check_sql_expr(expr->query);`
	`1990`	`+`
`1989`	`1991`	`if (have_into)`
`1990`	`1992`	`{`
`1991`	`1993`	`PLpgSQL_stmt_select *select;`