Log the actual timezone name that we fail to look up the values for in

mhagander · mhagander · commit 26eb0c72ab56 · 2010-04-06T20:35:11.000Z
case the registry data doesn't follow the format we expect, to facilitate
debugging.
diff --git a/src/timezone/pgtz.c b/src/timezone/pgtz.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/timezone/pgtz.c,v 1.67 2010/03/12 21:40:36 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/timezone/pgtz.c,v 1.68 2010/04/06 20:35:11 mha Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1091,7 +1091,8 @@ identify_system_timezone(void)
 		if ((r = RegQueryValueEx(key, "Std", NULL, NULL, zonename, &namesize)) != ERROR_SUCCESS)
 		{
 			ereport(WARNING,
-					(errmsg_internal("could not query value for 'std' to identify Windows timezone: %i", (int) r)));
+					(errmsg_internal("could not query value for 'std' to identify Windows timezone \"%s\": %i",
+									 keyname, (int) r)));
 			RegCloseKey(key);
 			break;
 		}
@@ -1107,7 +1108,8 @@ identify_system_timezone(void)
 		if ((r = RegQueryValueEx(key, "Dlt", NULL, NULL, zonename, &namesize)) != ERROR_SUCCESS)
 		{
 			ereport(WARNING,
-					(errmsg_internal("could not query value for 'dlt' to identify Windows timezone: %i", (int) r)));
+					(errmsg_internal("could not query value for 'dlt' to identify Windows timezone \"%s\": %i",
+									 keyname, (int) r)));
 			RegCloseKey(key);
 			break;
 		}

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group`
`7`	`7`	`*`
`8`	`8`	`* IDENTIFICATION`
`9`		`- * $PostgreSQL: pgsql/src/timezone/pgtz.c,v 1.67 2010/03/12 21:40:36 tgl Exp $`
	`9`	`+ * $PostgreSQL: pgsql/src/timezone/pgtz.c,v 1.68 2010/04/06 20:35:11 mha Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -1091,7 +1091,8 @@ identify_system_timezone(void)`
`1091`	`1091`	`if ((r = RegQueryValueEx(key, "Std", NULL, NULL, zonename, &namesize)) != ERROR_SUCCESS)`
`1092`	`1092`	`{`
`1093`	`1093`	`ereport(WARNING,`
`1094`		`- (errmsg_internal("could not query value for 'std' to identify Windows timezone: %i", (int) r)));`
	`1094`	`+ (errmsg_internal("could not query value for 'std' to identify Windows timezone \"%s\": %i",`
	`1095`	`+ keyname, (int) r)));`
`1095`	`1096`	`RegCloseKey(key);`
`1096`	`1097`	`break;`
`1097`	`1098`	`}`
`@@ -1107,7 +1108,8 @@ identify_system_timezone(void)`
`1107`	`1108`	`if ((r = RegQueryValueEx(key, "Dlt", NULL, NULL, zonename, &namesize)) != ERROR_SUCCESS)`
`1108`	`1109`	`{`
`1109`	`1110`	`ereport(WARNING,`
`1110`		`- (errmsg_internal("could not query value for 'dlt' to identify Windows timezone: %i", (int) r)));`
	`1111`	`+ (errmsg_internal("could not query value for 'dlt' to identify Windows timezone \"%s\": %i",`
	`1112`	`+ keyname, (int) r)));`
`1111`	`1113`	`RegCloseKey(key);`
`1112`	`1114`	`break;`
`1113`	`1115`	`}`