After closing frontend socket, set MyProcPort->sock = -1 to ensure that

tglsfdc · tglsfdc · commit 2af53f376251 · 2000-05-26T01:26:19.000Z
subsequent I/O attempts fail cleanly.  I'm speculating about failure
scenarios in which we do pq_close, then something in a proc_exit routine
opens a file (re-using that kernel FD number), then something else
fails and tries to write an elog message to the frontend ... message
ends up in opened file, oops.  No known examples of this but it seems
like a potential hole.
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
@@ -29,7 +29,7 @@
  * Portions Copyright (c) 1996-2000, PostgreSQL, Inc
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$Id: pqcomm.c,v 1.91 2000/05/21 21:19:53 tgl Exp $
+ *	$Id: pqcomm.c,v 1.92 2000/05/26 01:26:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -144,7 +144,11 @@ void
 pq_close(void)
 {
 	if (MyProcPort != NULL)
+	{
 		close(MyProcPort->sock);
+		/* make sure any subsequent attempts to do I/O fail cleanly */
+		MyProcPort->sock = -1;
+	}
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`* Portions Copyright (c) 1996-2000, PostgreSQL, Inc`
`30`	`30`	`* Portions Copyright (c) 1994, Regents of the University of California`
`31`	`31`	`*`
`32`		`- * $Id: pqcomm.c,v 1.91 2000/05/21 21:19:53 tgl Exp $`
	`32`	`+ * $Id: pqcomm.c,v 1.92 2000/05/26 01:26:19 tgl Exp $`
`33`	`33`	`*`
`34`	`34`	`*-------------------------------------------------------------------------`
`35`	`35`	`*/`
`@@ -144,7 +144,11 @@ void`
`144`	`144`	`pq_close(void)`
`145`	`145`	`{`
`146`	`146`	`if (MyProcPort != NULL)`
	`147`	`+ {`
`147`	`148`	`close(MyProcPort->sock);`
	`149`	`+ /* make sure any subsequent attempts to do I/O fail cleanly */`
	`150`	`+ MyProcPort->sock = -1;`
	`151`	`+ }`
`148`	`152`	`}`
`149`	`153`
`150`	`154`