Skip to content

Commit 324efc0

Browse files
committed
Removed requirements wal_log_hints = on for pg_arman work.
1 parent 44ac5f4 commit 324efc0

File tree

4 files changed

+1
-13
lines changed

4 files changed

+1
-13
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ You need to enable WAL archive by adding following lines to postgresql.conf:
102102
```
103103
wal_level = archive
104104
archive_command = 'test ! -f /home/postgres/backup/arman/wal/%f && cp %p /home/postgres/backup/arman/wal/%f'
105-
wal_log_hints = on
106105
```
107106

108107
Example backup (assuming PostgreSQL is running):

doc/pg_arman.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,6 @@ are required if the value contains whitespaces. Comments should start with
389389
excluding values.
390390

391391
### RESTRICTIONS
392-
* In order to work, the PostgreSQL instance on which backups are taken need
393-
to have data checksums enabled or to enable wal_log_hints.
394392
* pg_arman is aimed at working with PostgreSQL 9.5 and newer versions.
395393
* For ptrack feature you need special version of Postgres and set wal_level to
396394
archive or hot_standby and ptrack_enable.

sql/common.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ function init_backup()
7070
port = ${TEST_PGPORT}
7171
logging_collector = on
7272
wal_level = hot_standby
73-
wal_log_hints = on
73+
wal_log_hints = off
7474
archive_mode = on
7575
archive_command = 'cp %p ${ARCLOG_PATH}/%f'
7676
ptrack_enable = on

util.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,6 @@ sanityChecks(void)
8484
digestControlFile(&ControlFile, buffer, size);
8585
pg_free(buffer);
8686

87-
/*
88-
* Node work is done on need to use checksums or hint bit wal-logging
89-
* this to prevent from data corruption that could occur because of
90-
* hint bits.
91-
*/
92-
if (ControlFile.data_checksum_version != PG_DATA_CHECKSUM_VERSION &&
93-
!ControlFile.wal_log_hints)
94-
elog(ERROR,
95-
"target master need to use either data checksums or \"wal_log_hints = on\".");
9687
}
9788

9889
XLogRecPtr

0 commit comments

Comments
 (0)