check if operator + and - are available for given type in append_range_partition() and prepend_range_partition() functions

zilder · zilder · commit 3999694c6d7a · 2017-02-27T18:26:51.000+03:00
diff --git a/init.sql b/init.sql
@@ -896,3 +896,13 @@ CREATE OR REPLACE FUNCTION @extschema@.invoke_on_partition_created_callback(
 	init_callback	REGPROCEDURE)
 RETURNS VOID AS 'pg_pathman', 'invoke_on_partition_created_callback'
 LANGUAGE C;
+
+/*
+ *
+ */
+CREATE OR REPLACE FUNCTION @extschema@.is_operator_supported(
+	type_oid	OID,
+	opname		TEXT)
+RETURNS BOOLEAN AS 'pg_pathman', 'is_operator_supported'
+LANGUAGE C;
+
diff --git a/range.sql b/range.sql
@@ -573,6 +573,10 @@ BEGIN
 
 	v_atttype := @extschema@.get_partition_key_type(parent_relid);
 
+	IF NOT @extschema@.is_operator_supported(v_atttype, '+') THEN
+		RAISE EXCEPTION 'Type % doesn''t support ''+'' operator', v_atttype::regtype;
+	END IF;
+
 	SELECT range_interval
 	FROM @extschema@.pathman_config
 	WHERE partrel = parent_relid
@@ -678,6 +682,10 @@ BEGIN
 
 	v_atttype := @extschema@.get_partition_key_type(parent_relid);
 
+	IF NOT @extschema@.is_operator_supported(v_atttype, '-') THEN
+		RAISE EXCEPTION 'Type % doesn''t support ''-'' operator', v_atttype::regtype;
+	END IF;
+
 	SELECT range_interval
 	FROM @extschema@.pathman_config
 	WHERE partrel = parent_relid
diff --git a/src/pl_funcs.c b/src/pl_funcs.c
@@ -69,6 +69,8 @@ PG_FUNCTION_INFO_V1( check_security_policy );
 PG_FUNCTION_INFO_V1( debug_capture );
 PG_FUNCTION_INFO_V1( get_pathman_lib_version );
 
+PG_FUNCTION_INFO_V1( is_operator_supported );
+
 
 /*
  * User context for function show_partition_list_internal().
@@ -900,6 +902,20 @@ check_security_policy(PG_FUNCTION_ARGS)
 	PG_RETURN_BOOL(true);
 }
 
+Datum
+is_operator_supported(PG_FUNCTION_ARGS)
+{
+	Oid		tp = PG_GETARG_OID(0);
+	char   *opname = TextDatumGetCString(PG_GETARG_TEXT_P(1));
+	Oid		opid;
+
+	opid = compatible_oper_opid(list_make1(makeString(opname)), tp, tp, true);
+	if (!OidIsValid(opid))
+		PG_RETURN_BOOL(false);
+
+	PG_RETURN_BOOL(true);
+}
+
 
 /*
  * -------
diff --git a/src/pl_range_funcs.c b/src/pl_range_funcs.c
@@ -795,7 +795,7 @@ interval_is_trivial(Oid atttype, Datum interval, Oid interval_type)
 	/*
 	 * If operator result type isn't the same as original value then
 	 * convert it. We need this to make sure that specified interval would
-	 * change the _origianal_ value somehow. For example, if we add one second
+	 * change the _original_ value somehow. For example, if we add one second
 	 * to a date then we'll get a timestamp which is one second later than
 	 * original date (obviously). But when we convert it back to a date we will
 	 * get the same original value meaning that one second interval wouldn't
