Don't rename .partial files in pg_receivexlog if an error occured

mhagander · mhagander · commit 3ea56fffd66f · 2016-12-27T10:37:11.000+01:00
In 56c7d8d the behavior to keep .partial segments around (considered corrupt) in case an connection failure occurs was accidentally removed. This would lead to an incomplete segment being considered complete. Author: Michael Paquier
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -679,7 +679,7 @@ ReceiveXlogStream(PGconn *conn, StreamCtl *stream)
 	}
 
 error:
-	if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NORMAL) != 0)
+	if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NO_RENAME) != 0)
 		fprintf(stderr, _("%s: could not close file \"%s\": %s\n"),
 		  progname, current_walfile_name, stream->walmethod->getlasterror());
 	walfile = NULL;

Original file line number	Diff line number	Diff line change
`@@ -679,7 +679,7 @@ ReceiveXlogStream(PGconn conn, StreamCtl stream)`
`679`	`679`	`}`
`680`	`680`
`681`	`681`	`error:`
`682`		`- if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NORMAL) != 0)`
	`682`	`+ if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NO_RENAME) != 0)`
`683`	`683`	`fprintf(stderr, _("%s: could not close file \"%s\": %s\n"),`
`684`	`684`	`progname, current_walfile_name, stream->walmethod->getlasterror());`
`685`	`685`	`walfile = NULL;`