Improve error message when repack against non-existing table.

bwtakacy · bwtakacy · commit 49e542a0b696 · 2015-01-16T10:21:17.000+09:00
Previously, pg_repack shows "ERROR: ERROR: relation foo does not
exist" when specify non-existing table. Though the first ERROR
is from pg_repack and the second ERROR is from PostgreSQL server,
some users might think that pg_repack shows error level twice
wrongly.
diff --git a/bin/pg_repack.c b/bin/pg_repack.c
@@ -341,7 +341,7 @@ main(int argc, char *argv[])
 		{
 			if (!repack_one_database(orderby, errbuf, sizeof(errbuf)))
 				ereport(ERROR,
-					(errcode(ERROR), errmsg("%s", errbuf)));
+					(errcode(ERROR), errmsg("pg_repack fails by PostgreSQL server error: %s", errbuf)));
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ main(int argc, char *argv[])`
`341`	`341`	`{`
`342`	`342`	`if (!repack_one_database(orderby, errbuf, sizeof(errbuf)))`
`343`	`343`	`ereport(ERROR,`
`344`		`- (errcode(ERROR), errmsg("%s", errbuf)));`
	`344`	`+ (errcode(ERROR), errmsg("pg_repack fails by PostgreSQL server error: %s", errbuf)));`
`345`	`345`	`}`
`346`	`346`	`}`
`347`	`347`