Make the 'repacking index ...' message be displayed

schmiddy · schmiddy · commit 4eb1cef99e2c · 2014-05-24T00:09:03.000-04:00
for indexes-only repacks (not just when in dry-run mode).
diff --git a/bin/pg_repack.c b/bin/pg_repack.c
@@ -1683,6 +1683,7 @@ repack_table_indexes(PGresult *index_details)
 							 "WHERE pgc.relname = 'index_%u' "
 							 "AND nsp.nspname = $1", index);
 			params[0] = schema_name;
+			elog(INFO, "repacking index \"%s\".\"index_%u\"", schema_name, index);
 			res = execute(sql.data, 1, params);
 			if (PQresultStatus(res) != PGRES_TUPLES_OK)
 			{
@@ -1705,10 +1706,7 @@ repack_table_indexes(PGresult *index_details)
 			}
 
 			if (dryrun)
-			{
-				elog(INFO, "repacking index \"%s\".\"index_%u\"", schema_name, index);
 				continue;
-			}
 
 			params[0] = utoa(index, buffer[0]);
 			res = execute("SELECT repack.repack_indexdef($1, $2, $3, true)", 3,
diff --git a/regress/expected/repack.out b/regress/expected/repack.out
@@ -323,6 +323,9 @@ INFO: repacking table "tbl_nn_uk"
 \! pg_repack --dbname=contrib_regression --table=tbl_pk_uk
 INFO: repacking table "tbl_pk_uk"
 -- => OK
+\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk --only-indexes
+INFO: repacking indexes of "tbl_pk_uk"
+-- => OK
 \! pg_repack --dbname=contrib_regression --table=tbl_nn_puk
 WARNING: relation "tbl_nn_puk" must have a primary key or not-null unique keys
 -- => WARNING
diff --git a/regress/sql/repack.sql b/regress/sql/repack.sql
@@ -185,6 +185,8 @@ CREATE UNIQUE INDEX tbl_nn_puk_pcol1_idx ON tbl_nn_puk(col1) WHERE col1 < 10;
 -- => OK
 \! pg_repack --dbname=contrib_regression --table=tbl_pk_uk
 -- => OK
+\! pg_repack --dbname=contrib_regression --table=tbl_pk_uk --only-indexes
+-- => OK
 \! pg_repack --dbname=contrib_regression --table=tbl_nn_puk
 -- => WARNING
 
