Remember to close the file on failure (pretty much redundant, really,

tglsfdc · tglsfdc · commit 5666485aa8bb · 2004-11-12T00:08:23.000Z
since this path will lead to postmaster exit anyway...)
diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2000-2004, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.27 2004/11/11 23:45:13 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.28 2004/11/12 00:08:23 tgl Exp $
  */
 
 %{
@@ -214,6 +214,7 @@ ProcessConfigFile(GucContext context)
 					{
 						pfree(opt_name);
 						pfree(opt_value);
+						FreeFile(fp);
 						goto cleanup_exit;
 					}
 					pfree(opt_name);

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`*`
`5`	`5`	`* Copyright (c) 2000-2004, PostgreSQL Global Development Group`
`6`	`6`	`*`
`7`		`- * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.27 2004/11/11 23:45:13 tgl Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.28 2004/11/12 00:08:23 tgl Exp $`
`8`	`8`	`*/`
`9`	`9`
`10`	`10`	`%{`
`@@ -214,6 +214,7 @@ ProcessConfigFile(GucContext context)`
`214`	`214`	`{`
`215`	`215`	`pfree(opt_name);`
`216`	`216`	`pfree(opt_value);`
	`217`	`+ FreeFile(fp);`
`217`	`218`	`goto cleanup_exit;`
`218`	`219`	`}`
`219`	`220`	`pfree(opt_name);`