Remove troublesome type coersions from the char8 return statements.

Thomas G. Lockhart · Thomas G. Lockhart · commit 5bc1024225d1 · 1997-05-17T06:20:34.000Z
Noted in trying to port to AIX.
diff --git a/src/backend/utils/adt/char.c b/src/backend/utils/adt/char.c
@@ -12,7 +12,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/utils/adt/char.c,v 1.3 1997/03/14 23:19:54 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/utils/adt/char.c,v 1.4 1997/05/17 06:20:34 thomas Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -179,30 +179,30 @@ bool char16lt(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) (strncmp(arg1, arg2, 16) < 0));
+    return(strncmp(arg1, arg2, 16) < 0);
 }
 
 bool char16le(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) (strncmp(arg1, arg2, 16) <= 0));
+    return(strncmp(arg1, arg2, 16) <= 0);
 }
 
 bool char16gt(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
     
-    return((bool) (strncmp(arg1, arg2, 16) > 0));
+    return(strncmp(arg1, arg2, 16) > 0);
 }
 
 bool char16ge(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
     
-    return((bool) (strncmp(arg1, arg2, 16) >= 0));
+    return(strncmp(arg1, arg2, 16) >= 0);
 }
 
 
@@ -355,42 +355,42 @@ bool char8eq(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) strncmp(arg1, arg2, 8) == 0);
+    return(strncmp(arg1, arg2, 8) == 0);
 }
 
 bool char8ne(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) strncmp(arg1, arg2, 8) != 0);
+    return(strncmp(arg1, arg2, 8) != 0);
 }
 
 bool char8lt(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) strncmp(arg1, arg2, 8) < 0);
+    return(strncmp(arg1, arg2, 8) < 0);
 }
 
 bool char8le(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) strncmp(arg1, arg2, 8) <= 0);
+    return(strncmp(arg1, arg2, 8) <= 0);
 }
 
 bool char8gt(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) strncmp(arg1, arg2, 8) > 0);
+    return(strncmp(arg1, arg2, 8) > 0);
 }
 
 bool char8ge(char *arg1, char *arg2)
 {
     if (arg1 == NULL || arg2 == NULL)
 	return((bool) 0);
-    return((bool) strncmp(arg1, arg2, 8) >= 0);
+    return(strncmp(arg1, arg2, 8) >= 0);
 }
 
 int32 char8cmp(char *arg1, char *arg2)

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/char.c,v 1.3 1997/03/14 23:19:54 scrappy Exp $`
	`15`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/char.c,v 1.4 1997/05/17 06:20:34 thomas Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -179,30 +179,30 @@ bool char16lt(char arg1, char arg2)`
`179`	`179`	`{`
`180`	`180`	`if (arg1 == NULL \|\| arg2 == NULL)`
`181`	`181`	`return((bool) 0);`
`182`		`- return((bool) (strncmp(arg1, arg2, 16) < 0));`
	`182`	`+ return(strncmp(arg1, arg2, 16) < 0);`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`bool char16le(char arg1, char arg2)`
`186`	`186`	`{`
`187`	`187`	`if (arg1 == NULL \|\| arg2 == NULL)`
`188`	`188`	`return((bool) 0);`
`189`		`- return((bool) (strncmp(arg1, arg2, 16) <= 0));`
	`189`	`+ return(strncmp(arg1, arg2, 16) <= 0);`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`bool char16gt(char arg1, char arg2)`
`193`	`193`	`{`
`194`	`194`	`if (arg1 == NULL \|\| arg2 == NULL)`
`195`	`195`	`return((bool) 0);`
`196`	`196`
`197`		`- return((bool) (strncmp(arg1, arg2, 16) > 0));`
	`197`	`+ return(strncmp(arg1, arg2, 16) > 0);`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`bool char16ge(char arg1, char arg2)`
`201`	`201`	`{`
`202`	`202`	`if (arg1 == NULL \|\| arg2 == NULL)`
`203`	`203`	`return((bool) 0);`
`204`	`204`
`205`		`- return((bool) (strncmp(arg1, arg2, 16) >= 0));`
	`205`	`+ return(strncmp(arg1, arg2, 16) >= 0);`
`206`	`206`	`}`
`207`	`207`
`208`	`208`
`@@ -355,42 +355,42 @@ bool char8eq(char arg1, char arg2)`
`355`	`355`	`{`
`356`	`356`	`if (arg1 == NULL \|\| arg2 == NULL)`
`357`	`357`	`return((bool) 0);`
`358`		`- return((bool) strncmp(arg1, arg2, 8) == 0);`
	`358`	`+ return(strncmp(arg1, arg2, 8) == 0);`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`bool char8ne(char arg1, char arg2)`
`362`	`362`	`{`
`363`	`363`	`if (arg1 == NULL \|\| arg2 == NULL)`
`364`	`364`	`return((bool) 0);`
`365`		`- return((bool) strncmp(arg1, arg2, 8) != 0);`
	`365`	`+ return(strncmp(arg1, arg2, 8) != 0);`
`366`	`366`	`}`
`367`	`367`
`368`	`368`	`bool char8lt(char arg1, char arg2)`
`369`	`369`	`{`
`370`	`370`	`if (arg1 == NULL \|\| arg2 == NULL)`
`371`	`371`	`return((bool) 0);`
`372`		`- return((bool) strncmp(arg1, arg2, 8) < 0);`
	`372`	`+ return(strncmp(arg1, arg2, 8) < 0);`
`373`	`373`	`}`
`374`	`374`
`375`	`375`	`bool char8le(char arg1, char arg2)`
`376`	`376`	`{`
`377`	`377`	`if (arg1 == NULL \|\| arg2 == NULL)`
`378`	`378`	`return((bool) 0);`
`379`		`- return((bool) strncmp(arg1, arg2, 8) <= 0);`
	`379`	`+ return(strncmp(arg1, arg2, 8) <= 0);`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	`bool char8gt(char arg1, char arg2)`
`383`	`383`	`{`
`384`	`384`	`if (arg1 == NULL \|\| arg2 == NULL)`
`385`	`385`	`return((bool) 0);`
`386`		`- return((bool) strncmp(arg1, arg2, 8) > 0);`
	`386`	`+ return(strncmp(arg1, arg2, 8) > 0);`
`387`	`387`	`}`
`388`	`388`
`389`	`389`	`bool char8ge(char arg1, char arg2)`
`390`	`390`	`{`
`391`	`391`	`if (arg1 == NULL \|\| arg2 == NULL)`
`392`	`392`	`return((bool) 0);`
`393`		`- return((bool) strncmp(arg1, arg2, 8) >= 0);`
	`393`	`+ return(strncmp(arg1, arg2, 8) >= 0);`
`394`	`394`	`}`
`395`	`395`
`396`	`396`	`int32 char8cmp(char arg1, char arg2)`