Include the current value of max_stack_depth in stack depth complaints.

tglsfdc · tglsfdc · commit 6736916f5f5a · 2010-11-04T17:15:38.000-04:00
I'm mainly interested in finding out what it is on buildfarm machines,
but including the active value in the message seems like good practice
in any case.  Add the info to the HINT, not the ERROR string, so as not
to change the regression tests' expected output.
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
@@ -3021,8 +3021,9 @@ check_stack_depth(void)
 		ereport(ERROR,
 				(errcode(ERRCODE_STATEMENT_TOO_COMPLEX),
 				 errmsg("stack depth limit exceeded"),
-		 errhint("Increase the configuration parameter \"max_stack_depth\", "
-		   "after ensuring the platform's stack depth limit is adequate.")));
+				 errhint("Increase the configuration parameter \"max_stack_depth\" (currently %dkB), "
+						 "after ensuring the platform's stack depth limit is adequate.",
+						 max_stack_depth)));
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3021,8 +3021,9 @@ check_stack_depth(void)`
`3021`	`3021`	`ereport(ERROR,`
`3022`	`3022`	`(errcode(ERRCODE_STATEMENT_TOO_COMPLEX),`
`3023`	`3023`	`errmsg("stack depth limit exceeded"),`
`3024`		`- errhint("Increase the configuration parameter \"max_stack_depth\", "`
`3025`		`- "after ensuring the platform's stack depth limit is adequate.")));`
	`3024`	`+ errhint("Increase the configuration parameter \"max_stack_depth\" (currently %dkB), "`
	`3025`	`+ "after ensuring the platform's stack depth limit is adequate.",`
	`3026`	`+ max_stack_depth)));`
`3026`	`3027`	`}`
`3027`	`3028`	`}`
`3028`	`3029`