Add MtmNodeId range check.

kvap · kvap · commit 69d10b1dd8b0 · 2016-08-11T18:57:15.000+03:00
diff --git a/contrib/mmts/multimaster.c b/contrib/mmts/multimaster.c
@@ -1860,7 +1860,10 @@ static void MtmSplitConnStrs(void)
 	}
 	if (i > MAX_NODES) { 
 		elog(ERROR, "Multimaster with more than %d nodes is not currently supported", MAX_NODES);
-	}	
+	}
+	if (MtmNodeId > i) {
+		elog(ERROR, "Multimaster node id %d is out of range [%d..%d]", MtmNodeId, 1, i);
+	}
 	if (i < 2) { 
         elog(ERROR, "Multimaster should have at least two nodes");
 	}	

Original file line number	Diff line number	Diff line change
`@@ -1860,7 +1860,10 @@ static void MtmSplitConnStrs(void)`
`1860`	`1860`	`}`
`1861`	`1861`	`if (i > MAX_NODES) {`
`1862`	`1862`	`elog(ERROR, "Multimaster with more than %d nodes is not currently supported", MAX_NODES);`
`1863`		`- }`
	`1863`	`+ }`
	`1864`	`+ if (MtmNodeId > i) {`
	`1865`	`+ elog(ERROR, "Multimaster node id %d is out of range [%d..%d]", MtmNodeId, 1, i);`
	`1866`	`+ }`
`1864`	`1867`	`if (i < 2) {`
`1865`	`1868`	`elog(ERROR, "Multimaster should have at least two nodes");`
`1866`	`1869`	`}`