Fix double-free bug with -a (--all) option.

ItGacky · ItGacky · commit 6e05a366fa28 · 2010-05-14T06:52:45.000Z
diff --git a/bin/pgut/pgut-fe.c b/bin/pgut/pgut-fe.c
@@ -56,10 +56,11 @@ reconnect(int elevel)
 	if (connection)
 	{
 		new_password = PQpass(connection);
-		if (new_password && (!password || strcmp(new_password, password)))
+		if (new_password && new_password[0] &&
+			(password == NULL || strcmp(new_password, password) != 0))
 		{
 			free(password);
-			password = new_password;
+			password = pgut_strdup(new_password);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -56,10 +56,11 @@ reconnect(int elevel)`
`56`	`56`	`if (connection)`
`57`	`57`	`{`
`58`	`58`	`new_password = PQpass(connection);`
`59`		`- if (new_password && (!password \|\| strcmp(new_password, password)))`
	`59`	`+ if (new_password && new_password[0] &&`
	`60`	`+ (password == NULL \|\| strcmp(new_password, password) != 0))`
`60`	`61`	`{`
`61`	`62`	`free(password);`
`62`		`- password = new_password;`
	`63`	`+ password = pgut_strdup(new_password);`
`63`	`64`	`}`
`64`	`65`	`}`
`65`	`66`