improve error message for case when default range interval is NULL

funbringer · funbringer · commit 6ee0093417d8 · 2017-05-05T16:06:07.000+03:00
diff --git a/expected/pathman_interval.out b/expected/pathman_interval.out
@@ -18,7 +18,7 @@ SELECT set_interval('test_interval.abc', NULL::INT2);
 
 /* pg_pathman shouldn't be able to create a new partition */
 INSERT INTO test_interval.abc VALUES (250);
-ERROR:  cannot find appropriate partition for key '250'
+ERROR:  cannot spawn new partition for key '250'
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
 ERROR:  interval should not be trivial
@@ -61,7 +61,7 @@ SELECT set_interval('test_interval.abc', NULL::INT4);
 
 /* pg_pathman shouldn't be able to create a new partition */
 INSERT INTO test_interval.abc VALUES (250);
-ERROR:  cannot find appropriate partition for key '250'
+ERROR:  cannot spawn new partition for key '250'
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
 ERROR:  interval should not be trivial
@@ -104,7 +104,7 @@ SELECT set_interval('test_interval.abc', NULL::INT8);
 
 /* pg_pathman shouldn't be able to create a new partition */
 INSERT INTO test_interval.abc VALUES (250);
-ERROR:  cannot find appropriate partition for key '250'
+ERROR:  cannot spawn new partition for key '250'
 /* Set a trivial interval */
 SELECT set_interval('test_interval.abc', 0);
 ERROR:  interval should not be trivial
diff --git a/src/partition_creation.c b/src/partition_creation.c
@@ -408,9 +408,11 @@ create_partitions_for_value_internal(Oid relid, Datum value, Oid value_type,
 				/* Check if interval is set */
 				if (isnull[Anum_pathman_config_range_interval - 1])
 				{
-					elog(ERROR,
-						 "cannot find appropriate partition for key '%s'",
-						 datum_to_cstring(value, value_type));
+					ereport(ERROR,
+							(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+							 errmsg("cannot spawn new partition for key '%s'",
+									datum_to_cstring(value, value_type)),
+							 errdetail("default range interval is NULL")));
 				}
 
 				/* Retrieve interval as TEXT from tuple */

Original file line number	Diff line number	Diff line change
`@@ -408,9 +408,11 @@ create_partitions_for_value_internal(Oid relid, Datum value, Oid value_type,`
`408`	`408`	`/* Check if interval is set */`
`409`	`409`	`if (isnull[Anum_pathman_config_range_interval - 1])`
`410`	`410`	`{`
`411`		`- elog(ERROR,`
`412`		`- "cannot find appropriate partition for key '%s'",`
`413`		`- datum_to_cstring(value, value_type));`
	`411`	`+ ereport(ERROR,`
	`412`	`+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`413`	`+ errmsg("cannot spawn new partition for key '%s'",`
	`414`	`+ datum_to_cstring(value, value_type)),`
	`415`	`+ errdetail("default range interval is NULL")));`
`414`	`416`	`}`
`415`	`417`
`416`	`418`	`/* Retrieve interval as TEXT from tuple */`