Delete unused system table pg_parg.

tglsfdc · tglsfdc · commit 763a7ab6b003 · 1999-03-27T17:26:26.000Z
diff --git a/contrib/findoidjoins/README b/contrib/findoidjoins/README
@@ -1,23 +1,27 @@
 
    			      findoidjoins
 
-This program scans a database, and prints oid fields and the tables
-they join to.  CAUTION: it is ver-r-r-y slow on a large database, or
-even a not-so-large one.  We don't really recommend running it on
-anything but an empty database.
+This program scans a database, and prints oid fields (also regproc fields)
+and the tables they join to.  CAUTION: it is ver-r-r-y slow on a large
+database, or even a not-so-large one.  We don't really recommend running
+it on anything but an empty database.
 
 It requires pgsql/contrib/pginterface to be compiled first.
 
-Run on an empty database, it returns the system join relationships
-(shown below for 6.5).  Note that unexpected matches may indicate
-bogus entries in system tables --- don't accept a peculiar match
-without question.  In particular, a field shown as joining to more
-than one target table is probably messed up.
+Run on an empty database, it returns the system join relationships (shown
+below for 6.5).  Note that unexpected matches may indicate bogus entries
+in system tables --- don't accept a peculiar match without question.
+In particular, a field shown as joining to more than one target table is
+probably messed up.  In 6.5, the *only* field that should join to more
+than one target is pg_description.objoid.  (Running make_oidjoins_check
+is an easy way to spot fields joining to more than one table, BTW.)
 
 The shell script make_oidjoins_check converts findoidjoins' output
 into an SQL script that checks for dangling links (entries in an
-OID column that don't match any row in the expected table).
-The result of this script should be installed as the "oidjoins"
+OID or REGPROC column that don't match any row in the expected table).
+Note that fields joining to more than one table are NOT processed.
+
+The result of make_oidjoins_check should be installed as the "oidjoins"
 regression test.  The oidjoins test should be updated after any
 revision in the patterns of cross-links between system tables.
 (Ideally we'd just regenerate the script as part of the regression
@@ -68,9 +72,6 @@ Join pg_operator.oprrsortop => pg_operator.oid
 Join pg_operator.oprcode => pg_proc.oid
 Join pg_operator.oprrest => pg_proc.oid
 Join pg_operator.oprjoin => pg_proc.oid
-Join pg_parg.parproid => pg_operator.oid
-Join pg_parg.parproid => pg_proc.oid
-Join pg_parg.partype => pg_type.oid
 Join pg_proc.prolang => pg_language.oid
 Join pg_proc.prorettype => pg_type.oid
 Join pg_rewrite.ev_class => pg_class.oid
diff --git a/src/backend/catalog/Makefile b/src/backend/catalog/Makefile
@@ -4,7 +4,7 @@
 #    Makefile for catalog
 #
 # IDENTIFICATION
-#    $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.16 1999/01/18 06:32:24 momjian Exp $
+#    $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.17 1999/03/27 17:25:09 tgl Exp $
 #
 #-------------------------------------------------------------------------
 
@@ -33,7 +33,7 @@ LOCALBKI_SRCS= $(addprefix ../../include/catalog/, \
                  pg_proc.h pg_type.h pg_attribute.h pg_class.h \
                  pg_inherits.h pg_index.h pg_statistic.h \
                  pg_operator.h pg_opclass.h pg_am.h pg_amop.h pg_amproc.h \
-                 pg_language.h pg_parg.h \
+                 pg_language.h \
                  pg_aggregate.h pg_ipl.h pg_inheritproc.h \
                  pg_rewrite.h pg_listener.h pg_description.h indexing.h \
                 )
diff --git a/src/include/catalog/pg_parg.h b/src/include/catalog/pg_parg.h
diff --git a/src/test/regress/expected/oidjoins.out b/src/test/regress/expected/oidjoins.out
@@ -326,14 +326,6 @@ oid|oprjoin
 ---+-------
 (0 rows)
 
-QUERY: SELECT	oid, pg_parg.partype
-FROM	pg_parg
-WHERE	pg_parg.partype != 0 AND
-	NOT EXISTS(SELECT * FROM pg_type AS t1 WHERE t1.oid = pg_parg.partype);
-oid|partype
----+-------
-(0 rows)
-
 QUERY: SELECT	oid, pg_proc.prolang
 FROM	pg_proc
 WHERE	pg_proc.prolang != 0 AND
diff --git a/src/test/regress/sql/oidjoins.sql b/src/test/regress/sql/oidjoins.sql
@@ -165,10 +165,6 @@ SELECT	oid, pg_operator.oprjoin
 FROM	pg_operator 
 WHERE	pg_operator.oprjoin != 0 AND 
 	NOT EXISTS(SELECT * FROM pg_proc AS t1 WHERE t1.oid = pg_operator.oprjoin);
-SELECT	oid, pg_parg.partype 
-FROM	pg_parg 
-WHERE	pg_parg.partype != 0 AND 
-	NOT EXISTS(SELECT * FROM pg_type AS t1 WHERE t1.oid = pg_parg.partype);
 SELECT	oid, pg_proc.prolang 
 FROM	pg_proc 
 WHERE	pg_proc.prolang != 0 AND 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`# Makefile for catalog`
`5`	`5`	`#`
`6`	`6`	`# IDENTIFICATION`
`7`		`-# $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.16 1999/01/18 06:32:24 momjian Exp $`
	`7`	`+# $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.17 1999/03/27 17:25:09 tgl Exp $`
`8`	`8`	`#`
`9`	`9`	`#-------------------------------------------------------------------------`
`10`	`10`
`@@ -33,7 +33,7 @@ LOCALBKI_SRCS= $(addprefix ../../include/catalog/, \`
`33`	`33`	`pg_proc.h pg_type.h pg_attribute.h pg_class.h \`
`34`	`34`	`pg_inherits.h pg_index.h pg_statistic.h \`
`35`	`35`	`pg_operator.h pg_opclass.h pg_am.h pg_amop.h pg_amproc.h \`
`36`		`- pg_language.h pg_parg.h \`
	`36`	`+ pg_language.h \`
`37`	`37`	`pg_aggregate.h pg_ipl.h pg_inheritproc.h \`
`38`	`38`	`pg_rewrite.h pg_listener.h pg_description.h indexing.h \`
`39`	`39`	`)`