get_relattval() should treat a NULL constant as a non-constant expression,

tglsfdc · tglsfdc · commit 8064a49f6f8e · 2000-04-16T01:55:45.000Z
since it has no way to indicate to its caller that the constant is
actually NULL.  This prevents coredump in cases like
  WHERE textfield &lt; null::text;
diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.65 2000/04/12 17:15:24 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.66 2000/04/16 01:55:45 tgl Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -790,7 +790,8 @@ get_relattval(Node *clause,
 
 	other = (*flag == 0) ? left : right;
 
-	if (IsA(other, Const))
+	if (IsA(other, Const) &&
+		!((Const *) other)->constisnull)
 	{
 		*constval = ((Const *) other)->constvalue;
 		*flag |= SEL_CONSTANT;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.65 2000/04/12 17:15:24 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.66 2000/04/16 01:55:45 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* HISTORY`
`14`	`14`	`* AUTHOR DATE MAJOR EVENT`
`@@ -790,7 +790,8 @@ get_relattval(Node *clause,`
`790`	`790`
`791`	`791`	`other = (*flag == 0) ? left : right;`
`792`	`792`
`793`		`- if (IsA(other, Const))`
	`793`	`+ if (IsA(other, Const) &&`
	`794`	`+ !((Const *) other)->constisnull)`
`794`	`795`	`{`
`795`	`796`	`constval = ((Const ) other)->constvalue;`
`796`	`797`	`*flag \|= SEL_CONSTANT;`