remove declaration of function get_attribute_type_pl(), more calamity tests

funbringer · funbringer · commit 819c07ecda4d · 2017-02-10T20:45:12.000+03:00
diff --git a/expected/pathman_calamity.out b/expected/pathman_calamity.out
@@ -389,9 +389,13 @@ ERROR:  'parent_relid' should not be NULL
 SELECT invoke_on_partition_created_callback('calamity.part_test', NULL, 1);
 ERROR:  'partition' should not be NULL
 /* check function add_to_pathman_config() -- PHASE #1 */
-SELECT add_to_pathman_config('calamity.part_test', NULL);
+SELECT add_to_pathman_config(NULL, 'val');						/* no table */
+ERROR:  'parent_relid' should not be NULL
+SELECT add_to_pathman_config('calamity.part_test', NULL);		/* no column */
 ERROR:  'attname' should not be NULL
-SELECT add_to_pathman_config('calamity.part_test', 'val');
+SELECT add_to_pathman_config('calamity.part_test', 'V_A_L');	/* wrong column */
+ERROR:  relation "part_test" has no column "V_A_L"
+SELECT add_to_pathman_config('calamity.part_test', 'val');		/* OK */
  add_to_pathman_config 
 -----------------------
  t
@@ -404,7 +408,7 @@ NOTICE:  function calamity.part_test_upd_trig_func() does not exist, skipping
  
 (1 row)
 
-SELECT add_to_pathman_config('calamity.part_test', 'val', '10');
+SELECT add_to_pathman_config('calamity.part_test', 'val', '10'); /* OK */
  add_to_pathman_config 
 -----------------------
  t
diff --git a/sql/pathman_calamity.sql b/sql/pathman_calamity.sql
@@ -140,10 +140,12 @@ SELECT invoke_on_partition_created_callback(NULL, 'calamity.part_test', 1);
 SELECT invoke_on_partition_created_callback('calamity.part_test', NULL, 1);
 
 /* check function add_to_pathman_config() -- PHASE #1 */
-SELECT add_to_pathman_config('calamity.part_test', NULL);
-SELECT add_to_pathman_config('calamity.part_test', 'val');
+SELECT add_to_pathman_config(NULL, 'val');						/* no table */
+SELECT add_to_pathman_config('calamity.part_test', NULL);		/* no column */
+SELECT add_to_pathman_config('calamity.part_test', 'V_A_L');	/* wrong column */
+SELECT add_to_pathman_config('calamity.part_test', 'val');		/* OK */
 SELECT disable_pathman_for('calamity.part_test');
-SELECT add_to_pathman_config('calamity.part_test', 'val', '10');
+SELECT add_to_pathman_config('calamity.part_test', 'val', '10'); /* OK */
 SELECT disable_pathman_for('calamity.part_test');
 
 
diff --git a/src/pl_funcs.c b/src/pl_funcs.c
@@ -41,7 +41,6 @@ PG_FUNCTION_INFO_V1( on_partitions_removed );
 PG_FUNCTION_INFO_V1( get_number_of_partitions_pl );
 PG_FUNCTION_INFO_V1( get_parent_of_partition_pl );
 PG_FUNCTION_INFO_V1( get_base_type_pl );
-PG_FUNCTION_INFO_V1( get_attribute_type_pl );
 PG_FUNCTION_INFO_V1( get_partition_key_type );
 PG_FUNCTION_INFO_V1( get_tablespace_pl );
 
