Don't accept names of complex types (ie, relation types) as being

tglsfdc · tglsfdc · commit 990eb8552e69 · 2001-12-12T03:28:49.000Z
requests for implicit trivial coercions.  Prevents sillinesses like
this one:
regression=# select x.int8_tbl.q1 from int8_tbl x;
ERROR:  fmgr_info: function 270997776: cache lookup failed
diff --git a/src/backend/parser/parse_func.c b/src/backend/parser/parse_func.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_func.c,v 1.114 2001/11/12 00:00:55 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_func.c,v 1.115 2001/12/12 03:28:49 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1165,7 +1165,8 @@ func_get_detail(char *funcname,
 			targetType = GetSysCacheOid(TYPENAME,
 										PointerGetDatum(funcname),
 										0, 0, 0);
-			if (OidIsValid(targetType))
+			if (OidIsValid(targetType) &&
+				!ISCOMPLEX(targetType))
 			{
 				Oid			sourceType = argtypes[0];
 				Node	   *arg1 = lfirst(fargs);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_func.c,v 1.114 2001/11/12 00:00:55 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_func.c,v 1.115 2001/12/12 03:28:49 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1165,7 +1165,8 @@ func_get_detail(char *funcname,`
`1165`	`1165`	`targetType = GetSysCacheOid(TYPENAME,`
`1166`	`1166`	`PointerGetDatum(funcname),`
`1167`	`1167`	`0, 0, 0);`
`1168`		`- if (OidIsValid(targetType))`
	`1168`	`+ if (OidIsValid(targetType) &&`
	`1169`	`+ !ISCOMPLEX(targetType))`
`1169`	`1170`	`{`
`1170`	`1171`	`Oid sourceType = argtypes[0];`
`1171`	`1172`	`Node *arg1 = lfirst(fargs);`