[PGPRO-4074] Port fix the foreign_key.sql regression test problem.

danolivo · arssher · commit 9ed770fa39fa · 2021-02-28T17:14:47.000+03:00
Cherry pick of

[PGPRO-3171] Fix the foreign_key.sql regression test problem.
We allow to apply transactions with temporary tables by any worker.
Each worker has MyBackendId. At the stage of initialization of temporary
relation into the relcache, it is set rel-&gt;rd_backend to MyBackendId.
If worker try to open the ralation it will use rd-backend field to construct the path.
If it is differ from the rd_backend of relation creator we catch the ERROR "could not open file ..."

Fix the problem by modify BackendIdForTempRelations() routine. Now all workers will
initialize its rd_backend field of corresponding temporary relation by the same value.

(cherry picked from commit fae6fc9b861fd7518cb5df8ae506b6f63c5434f6)

ars:
Funnily enough, the patch has been forgotten in v12 but I've failed to reproduce
the original issue there. I suspect it has to do with PGPRO-3124 patch who
delays temp table file creation as late as possible (which on receiver side in
mm should mean never create the file, as temp table is ever empty there), but
not 100% sure.

tags: multimaster
(cherry picked from commit 69036af77ebb5cc51f2733a5a6bcb76a780967d3)
diff --git a/src/backend/catalog/namespace.c b/src/backend/catalog/namespace.c
@@ -3326,6 +3326,28 @@ GetTempToastNamespace(void)
 	return myTempToastNamespace;
 }
 
+/*
+ * MTM-CRUTCH.
+ *
+ * The BackendId to use for our session's temp relations is normally our own,
+ * but parallel workers should use their leader's ID.
+ * In a multimaster configuration it is a session id from the node, which
+ * connected to the user.
+ */
+int
+BackendIdForTempRelations(void)
+{
+	Oid nspOid, tnspOid;
+
+	GetTempNamespaceState(&nspOid, &tnspOid);
+
+	if (OidIsValid(nspOid))
+		return GetTempNamespaceBackendId(nspOid);
+	else if(OidIsValid(tnspOid))
+		return GetTempNamespaceBackendId(tnspOid);
+	else
+		return ParallelMasterBackendId == InvalidBackendId ? MyBackendId : ParallelMasterBackendId;
+}
 
 /*
  * GetTempNamespaceState - fetch status of session's temporary namespace
diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c
@@ -25,6 +25,7 @@
 #include "access/xlog.h"
 #include "access/xloginsert.h"
 #include "access/xlogutils.h"
+#include "catalog/namespace.h"
 #include "catalog/storage.h"
 #include "catalog/storage_xlog.h"
 #include "miscadmin.h"
diff --git a/src/include/catalog/namespace.h b/src/include/catalog/namespace.h
@@ -156,6 +156,7 @@ extern bool isOtherTempNamespace(Oid namespaceId);
 extern TempNamespaceStatus checkTempNamespaceStatus(Oid namespaceId);
 extern int	GetTempNamespaceBackendId(Oid namespaceId);
 extern Oid	GetTempToastNamespace(void);
+extern int BackendIdForTempRelations(void);
 extern void GetTempNamespaceState(Oid *tempNamespaceId,
 								  Oid *tempToastNamespaceId);
 extern void SetTempNamespaceState(Oid tempNamespaceId,
diff --git a/src/include/storage/backendid.h b/src/include/storage/backendid.h
@@ -27,11 +27,4 @@ extern PGDLLIMPORT BackendId MyBackendId;	/* backend id of this backend */
 /* backend id of our parallel session leader, or InvalidBackendId if none */
 extern PGDLLIMPORT BackendId ParallelMasterBackendId;
 
-/*
- * The BackendId to use for our session's temp relations is normally our own,
- * but parallel workers should use their leader's ID.
- */
-#define BackendIdForTempRelations() \
-	(ParallelMasterBackendId == InvalidBackendId ? MyBackendId : ParallelMasterBackendId)
-
 #endif							/* BACKENDID_H */
