The call to DNSServiceRegistrationCreate in postmaster.c does incorrect

Neil Conway · Neil Conway · commit a5dba023593e · 2006-03-18T22:09:58.000Z
byte-swapping on the port number which causes the call to fail on Intel
Macs.

This patch uses htons() instead of htonl() and fixes this bug.

Ashley Clark
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.482 2006/03/05 15:58:36 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.483 2006/03/18 22:09:58 neilc Exp $
  *
  * NOTES
  *
@@ -810,7 +810,7 @@ PostmasterMain(int argc, char *argv[])
 		DNSServiceRegistrationCreate(bonjour_name,
 									 "_postgresql._tcp.",
 									 "",
-									 htonl(PostPortNumber),
+									 htons(PostPortNumber),
 									 "",
 									 (DNSServiceRegistrationReply) reg_reply,
 									 NULL);

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.482 2006/03/05 15:58:36 momjian Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.483 2006/03/18 22:09:58 neilc Exp $`
`41`	`41`	`*`
`42`	`42`	`* NOTES`
`43`	`43`	`*`
`@@ -810,7 +810,7 @@ PostmasterMain(int argc, char *argv[])`
`810`	`810`	`DNSServiceRegistrationCreate(bonjour_name,`
`811`	`811`	`"_postgresql._tcp.",`
`812`	`812`	`"",`
`813`		`- htonl(PostPortNumber),`
	`813`	`+ htons(PostPortNumber),`
`814`	`814`	`"",`
`815`	`815`	`(DNSServiceRegistrationReply) reg_reply,`
`816`	`816`	`NULL);`