Do not close spill file because it is automatically closed on transaction commit/rollback

knizhnik · knizhnik · commit a6db83317d6e · 2017-02-14T19:35:14.000+03:00
diff --git a/contrib/mmts/pglogical_apply.c b/contrib/mmts/pglogical_apply.c
@@ -1147,9 +1147,11 @@ void MtmExecutor(void* work, size_t size)
 		MTM_LOG2("%d: REMOTE end abort transaction %llu", MyProcPid, (long64)MtmGetCurrentTransactionId());
     }
     PG_END_TRY();
+#if 0 /* spill file is expecrted to be closed by tranaction commit or rollback */
 	if (spill_file >= 0) { 
 		MtmCloseSpillFile(spill_file);
 	}
+#endif
     MemoryContextResetAndDeleteChildren(MtmApplyContext);
 }
     

Original file line number	Diff line number	Diff line change
`@@ -1147,9 +1147,11 @@ void MtmExecutor(void* work, size_t size)`
`1147`	`1147`	`MTM_LOG2("%d: REMOTE end abort transaction %llu", MyProcPid, (long64)MtmGetCurrentTransactionId());`
`1148`	`1148`	`}`
`1149`	`1149`	`PG_END_TRY();`
	`1150`	`+#if 0 /* spill file is expecrted to be closed by tranaction commit or rollback */`
`1150`	`1151`	`if (spill_file >= 0) {`
`1151`	`1152`	`MtmCloseSpillFile(spill_file);`
`1152`	`1153`	`}`
	`1154`	`+#endif`
`1153`	`1155`	`MemoryContextResetAndDeleteChildren(MtmApplyContext);`
`1154`	`1156`	`}`
`1155`	`1157`