fix integer overflow in slot lag calculation =(

kelvich · kelvich · commit d5e6f2f916e9 · 2017-10-30T17:09:30.000+03:00
diff --git a/contrib/mmts/multimaster.c b/contrib/mmts/multimaster.c
@@ -2035,7 +2035,7 @@ MtmCheckSlots()
 			if (slot->in_use
 				&& sscanf(slot->data.name.data, MULTIMASTER_SLOT_PATTERN, &nodeId) == 1
 				&& BIT_CHECK(Mtm->disabledNodeMask, nodeId-1)
-				&& slot->data.confirmed_flush + MtmMaxRecoveryLag * 1024 < GetXLogInsertRecPtr()
+				&& slot->data.confirmed_flush + (long64) MtmMaxRecoveryLag * 1024 < GetXLogInsertRecPtr()
 				&& slot->data.confirmed_flush != 0)
 			{
 				MTM_ELOG(WARNING, "Drop slot for node %d which lag %lld B is larger than threshold %d kB",

Original file line number	Diff line number	Diff line change
`@@ -2035,7 +2035,7 @@ MtmCheckSlots()`
`2035`	`2035`	`if (slot->in_use`
`2036`	`2036`	`&& sscanf(slot->data.name.data, MULTIMASTER_SLOT_PATTERN, &nodeId) == 1`
`2037`	`2037`	`&& BIT_CHECK(Mtm->disabledNodeMask, nodeId-1)`
`2038`		`- && slot->data.confirmed_flush + MtmMaxRecoveryLag * 1024 < GetXLogInsertRecPtr()`
	`2038`	`+ && slot->data.confirmed_flush + (long64) MtmMaxRecoveryLag * 1024 < GetXLogInsertRecPtr()`
`2039`	`2039`	`&& slot->data.confirmed_flush != 0)`
`2040`	`2040`	`{`
`2041`	`2041`	`MTM_ELOG(WARNING, "Drop slot for node %d which lag %lld B is larger than threshold %d kB",`