comments

kelvich · kelvich · commit dc54e897a4e0 · 2016-01-22T20:30:17.000+03:00
diff --git a/reinit.sh b/reinit.sh
@@ -1,5 +1,8 @@
 #!/bin/sh
 
+# This script assumes that it is placed in postgres repository root,
+# and postgres configured with --prefix=$PG_REPO_ROOT/install
+
 reinit_master() {
 	rm -rf install/data
 
@@ -18,7 +21,7 @@ reinit_master() {
 
 	echo '---- test ----' >> ./install/logfile
 
-	echo 'local replication stas trust' >> ./install/data/pg_hba.conf
+	echo "local replication `whoami` trust" >> ./install/data/pg_hba.conf
 
 	./install/bin/pg_ctl -sw -D ./install/data -l ./install/logfile start
 }
@@ -41,7 +44,7 @@ reinit_slave() {
 }
 
 postinit(){
-	./install/bin/createdb stas
+	./install/bin/createdb `whoami`
 	./install/bin/psql -c "create table t(id int);"
 }
 
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
@@ -1665,6 +1665,11 @@ XlogRedoFinishPrepared(TransactionId xid)
 	ProcArrayRemove(proc, latestXid);
 	gxact->valid = false;
 
+	/*
+	 * 2REVIEWER: I assume that we can skip invalidation callbacks here,
+	 * aren't we?
+	 */
+
 	/* And release locks */
 	if (true)
 		ProcessRecords(bufptr, xid, twophase_postcommit_callbacks);

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`#!/bin/sh`
`2`	`2`
	`3`	`+# This script assumes that it is placed in postgres repository root,`
	`4`	`+# and postgres configured with --prefix=$PG_REPO_ROOT/install`
	`5`	`+`
`3`	`6`	`reinit_master() {`
`4`	`7`	`rm -rf install/data`
`5`	`8`
`@@ -18,7 +21,7 @@ reinit_master() {`
`18`	`21`
`19`	`22`	`echo '---- test ----' >> ./install/logfile`
`20`	`23`
`21`		`- echo 'local replication stas trust' >> ./install/data/pg_hba.conf`
	`24`	+ echo "local replication `whoami` trust" >> ./install/data/pg_hba.conf
`22`	`25`
`23`	`26`	`./install/bin/pg_ctl -sw -D ./install/data -l ./install/logfile start`
`24`	`27`	`}`
`@@ -41,7 +44,7 @@ reinit_slave() {`
`41`	`44`	`}`
`42`	`45`
`43`	`46`	`postinit(){`
`44`		`- ./install/bin/createdb stas`
	`47`	+ ./install/bin/createdb `whoami`
`45`	`48`	`./install/bin/psql -c "create table t(id int);"`
`46`	`49`	`}`
`47`	`50`