fixed bug reported by Michael, Dietrich (mdt@emdete.de) where a large object handle was being used after the end of the transaction and thus resulting in an error.

Barry Lind · Barry Lind · commit f170e61d9baf · 2002-07-05T18:50:27.000Z
diff --git a/src/interfaces/jdbc/org/postgresql/largeobject/LargeObject.java b/src/interfaces/jdbc/org/postgresql/largeobject/LargeObject.java
@@ -92,7 +92,12 @@ protected LargeObject(Fastpath fp, int oid, int mode) throws SQLException
 	/* Release large object resources during garbage cleanup */
 	protected void finalize() throws SQLException
 	{
-		close();
+	    //This code used to call close() however that was problematic
+	    //because the scope of the fd is a transaction, thus if commit
+	    //or rollback was called before garbage collection ran then 
+	    //the call to close would error out with an invalid large object
+	    //handle.  So this method now does nothing and lets the server
+	    //handle cleanup when it ends the transaction.
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,12 @@ protected LargeObject(Fastpath fp, int oid, int mode) throws SQLException`
`92`	`92`	`/* Release large object resources during garbage cleanup */`
`93`	`93`	`protected void finalize() throws SQLException`
`94`	`94`	`{`
`95`		`- close();`
	`95`	`+ //This code used to call close() however that was problematic`
	`96`	`+ //because the scope of the fd is a transaction, thus if commit`
	`97`	`+ //or rollback was called before garbage collection ran then`
	`98`	`+ //the call to close would error out with an invalid large object`
	`99`	`+ //handle. So this method now does nothing and lets the server`
	`100`	`+ //handle cleanup when it ends the transaction.`
`96`	`101`	`}`
`97`	`102`
`98`	`103`	`/*`