Report the true database name on connection errors

alvherre · alvherre · commit f17e8f33f781 · 2021-01-26T16:42:13.000-03:00
When reporting connection errors, we might show a database name in the message that's not the one we actually tried to connect to, if the database was taken from libpq defaults instead of from user parameters. Fix such error messages to use PQdb(), which reports the correct name. (But, per commit 2930c05, make sure not to try to print NULL.) Apply to branches 9.5 through 13. Branch master has already been changed differently by commit 58cd8dca3de0. Reported-by: Robert Haas <robertmhaas@gmail.com> Discussion: https://postgr.es/m/CA+TgmobssJ6rS22dspWnu-oDxXevGmhMD8VcRBjmj-b9UDqRjw@mail.gmail.com
diff --git a/contrib/oid2name/oid2name.c b/contrib/oid2name/oid2name.c
@@ -348,8 +348,8 @@ sql_conn(struct options *my_opts)
 	/* check to see that the backend connection was successfully made */
 	if (PQstatus(conn) == CONNECTION_BAD)
 	{
-		pg_log_error("could not connect to database %s: %s",
-					 my_opts->dbname, PQerrorMessage(conn));
+		pg_log_error("could not connect to database \"%s\": %s",
+					 PQdb(conn) ? PQdb(conn) : "", PQerrorMessage(conn));
 		PQfinish(conn);
 		exit(1);
 	}
diff --git a/contrib/vacuumlo/vacuumlo.c b/contrib/vacuumlo/vacuumlo.c
@@ -129,7 +129,7 @@ vacuumlo(const char *database, const struct _param *param)
 	if (PQstatus(conn) == CONNECTION_BAD)
 	{
 		pg_log_error("connection to database \"%s\" failed: %s",
-					 database, PQerrorMessage(conn));
+					 PQdb(conn) ? PQdb(conn) : "", PQerrorMessage(conn));
 		PQfinish(conn);
 		return -1;
 	}
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -1773,7 +1773,7 @@ connectDatabase(const char *dbname, const char *connection_string,
 		if (fail_on_error)
 		{
 			pg_log_error("could not connect to database \"%s\": %s",
-						 dbname, PQerrorMessage(conn));
+						 PQdb(conn) ? PQdb(conn) : "", PQerrorMessage(conn));
 			exit_nicely(1);
 		}
 		else
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -1228,7 +1228,7 @@ doConnect(void)
 	if (PQstatus(conn) == CONNECTION_BAD)
 	{
 		pg_log_error("connection to database \"%s\" failed: %s",
-					 dbName, PQerrorMessage(conn));
+					 PQdb(conn), PQerrorMessage(conn));
 		PQfinish(conn);
 		return NULL;
 	}
@@ -6047,7 +6047,7 @@ main(int argc, char **argv)
 	if (PQstatus(con) == CONNECTION_BAD)
 	{
 		pg_log_fatal("connection to database \"%s\" failed: %s",
-					 dbName, PQerrorMessage(con));
+					 PQdb(con) ? PQdb(con) : "", PQerrorMessage(con));
 		exit(1);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -348,8 +348,8 @@ sql_conn(struct options *my_opts)`
`348`	`348`	`/* check to see that the backend connection was successfully made */`
`349`	`349`	`if (PQstatus(conn) == CONNECTION_BAD)`
`350`	`350`	`{`
`351`		`- pg_log_error("could not connect to database %s: %s",`
`352`		`- my_opts->dbname, PQerrorMessage(conn));`
	`351`	`+ pg_log_error("could not connect to database \"%s\": %s",`
	`352`	`+ PQdb(conn) ? PQdb(conn) : "", PQerrorMessage(conn));`
`353`	`353`	`PQfinish(conn);`
`354`	`354`	`exit(1);`
`355`	`355`	`}`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ vacuumlo(const char database, const struct _param param)`
`129`	`129`	`if (PQstatus(conn) == CONNECTION_BAD)`
`130`	`130`	`{`
`131`	`131`	`pg_log_error("connection to database \"%s\" failed: %s",`
`132`		`- database, PQerrorMessage(conn));`
	`132`	`+ PQdb(conn) ? PQdb(conn) : "", PQerrorMessage(conn));`
`133`	`133`	`PQfinish(conn);`
`134`	`134`	`return -1;`
`135`	`135`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1773,7 +1773,7 @@ connectDatabase(const char dbname, const char connection_string,`
`1773`	`1773`	`if (fail_on_error)`
`1774`	`1774`	`{`
`1775`	`1775`	`pg_log_error("could not connect to database \"%s\": %s",`
`1776`		`- dbname, PQerrorMessage(conn));`
	`1776`	`+ PQdb(conn) ? PQdb(conn) : "", PQerrorMessage(conn));`
`1777`	`1777`	`exit_nicely(1);`
`1778`	`1778`	`}`
`1779`	`1779`	`else`
Original file line number	Diff line number	Diff line change
`@@ -1228,7 +1228,7 @@ doConnect(void)`
`1228`	`1228`	`if (PQstatus(conn) == CONNECTION_BAD)`
`1229`	`1229`	`{`
`1230`	`1230`	`pg_log_error("connection to database \"%s\" failed: %s",`
`1231`		`- dbName, PQerrorMessage(conn));`
	`1231`	`+ PQdb(conn), PQerrorMessage(conn));`
`1232`	`1232`	`PQfinish(conn);`
`1233`	`1233`	`return NULL;`
`1234`	`1234`	`}`
`@@ -6047,7 +6047,7 @@ main(int argc, char **argv)`
`6047`	`6047`	`if (PQstatus(con) == CONNECTION_BAD)`
`6048`	`6048`	`{`
`6049`	`6049`	`pg_log_fatal("connection to database \"%s\" failed: %s",`
`6050`		`- dbName, PQerrorMessage(con));`
	`6050`	`+ PQdb(con) ? PQdb(con) : "", PQerrorMessage(con));`
`6051`	`6051`	`exit(1);`
`6052`	`6052`	`}`
`6053`	`6053`