Shouldn't try to copy null datums with datumCopy.

tglsfdc · tglsfdc · commit f7fb29dec3a6 · 2002-01-03T18:01:59.000Z
diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.92 2001/12/10 22:54:12 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.93 2002/01/03 18:01:59 tgl Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -1544,7 +1544,8 @@ simplify_op_or_func(Expr *expr, List *args)
 										  &const_is_null, NULL);
 
 	/* Must copy result out of sub-context used by expression eval */
-	const_val = datumCopy(const_val, resultTypByVal, resultTypLen);
+	if (!const_is_null)
+		const_val = datumCopy(const_val, resultTypByVal, resultTypLen);
 
 	FreeExprContext(econtext);
 	pfree(newexpr);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.92 2001/12/10 22:54:12 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.93 2002/01/03 18:01:59 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* HISTORY`
`14`	`14`	`* AUTHOR DATE MAJOR EVENT`
`@@ -1544,7 +1544,8 @@ simplify_op_or_func(Expr expr, List args)`
`1544`	`1544`	`&const_is_null, NULL);`
`1545`	`1545`
`1546`	`1546`	`/* Must copy result out of sub-context used by expression eval */`
`1547`		`- const_val = datumCopy(const_val, resultTypByVal, resultTypLen);`
	`1547`	`+ if (!const_is_null)`
	`1548`	`+ const_val = datumCopy(const_val, resultTypByVal, resultTypLen);`
`1548`	`1549`
`1549`	`1550`	`FreeExprContext(econtext);`
`1550`	`1551`	`pfree(newexpr);`