Fixed --order-by broken by namespaces refactoring

dvarrazzo · dvarrazzo · commit f886e0dba66d · 2013-04-22T11:19:56.000+01:00
Also added a regression test for it.

Bug and patch from Beena Emerson, thany you.
diff --git a/bin/expected/tablespace.out b/bin/expected/tablespace.out
@@ -78,3 +78,6 @@ ORDER BY relname;
 ERROR: cannot specify --moveidx (-S) without --tablespace (-s)
 \! pg_repack --dbname=contrib_regression --no-order --table=testts1 -S
 ERROR: cannot specify --moveidx (-S) without --tablespace (-s)
+-- not broken with order
+\! pg_repack --dbname=contrib_regression -o id --table=testts1 --tablespace pg_default --moveidx
+INFO: repacking table "testts1"
diff --git a/bin/pg_repack.c b/bin/pg_repack.c
@@ -617,6 +617,7 @@ repack_one_database(const char *orderby, char *errbuf, size_t errsize)
 			/* User specified ORDER BY */
 			appendStringInfoString(&sql, " ORDER BY ");
 			appendStringInfoString(&sql, orderby);
+			table.create_table = sql.data;
 		}
 
 		repack_one_table(&table, orderby);
diff --git a/bin/sql/tablespace.sql b/bin/sql/tablespace.sql
@@ -53,3 +53,5 @@ ORDER BY relname;
 \! pg_repack --dbname=contrib_regression --no-order --table=testts1 --moveidx
 \! pg_repack --dbname=contrib_regression --no-order --table=testts1 -S
 
+-- not broken with order
+\! pg_repack --dbname=contrib_regression -o id --table=testts1 --tablespace pg_default --moveidx

Original file line number	Diff line number	Diff line change
`@@ -617,6 +617,7 @@ repack_one_database(const char orderby, char errbuf, size_t errsize)`
`617`	`617`	`/* User specified ORDER BY */`
`618`	`618`	`appendStringInfoString(&sql, " ORDER BY ");`
`619`	`619`	`appendStringInfoString(&sql, orderby);`
	`620`	`+ table.create_table = sql.data;`
`620`	`621`	`}`
`621`	`622`
`622`	`623`	`repack_one_table(&table, orderby);`