Wrong precedence for these chained less-than / greater-thans.

Josh Kupershmidt · Josh Kupershmidt · commit facbcf90dda0 · 2015-07-24T07:27:30.000-04:00
diff --git a/bin/pgut/pgut.c b/bin/pgut/pgut.c
@@ -1200,14 +1200,13 @@ on_cleanup(void)
 static void
 exit_or_abort(int exitcode, int elevel)
 {
-	
 	if (in_cleanup && FATAL > elevel)
 	{
 		/* oops, error in cleanup*/
 		call_atexit_callbacks(true);
 		exit(exitcode);
 	}
-	else if (FATAL <= elevel <= PANIC)
+	else if (elevel >= FATAL && elevel <= PANIC)
 	{
 		/* on FATAL or PANIC */
 		call_atexit_callbacks(true);

Original file line number	Diff line number	Diff line change
`@@ -1200,14 +1200,13 @@ on_cleanup(void)`
`1200`	`1200`	`static void`
`1201`	`1201`	`exit_or_abort(int exitcode, int elevel)`
`1202`	`1202`	`{`
`1203`		`-`
`1204`	`1203`	`if (in_cleanup && FATAL > elevel)`
`1205`	`1204`	`{`
`1206`	`1205`	`/* oops, error in cleanup*/`
`1207`	`1206`	`call_atexit_callbacks(true);`
`1208`	`1207`	`exit(exitcode);`
`1209`	`1208`	`}`
`1210`		`- else if (FATAL <= elevel <= PANIC)`
	`1209`	`+ else if (elevel >= FATAL && elevel <= PANIC)`
`1211`	`1210`	`{`
`1212`	`1211`	`/* on FATAL or PANIC */`
`1213`	`1212`	`call_atexit_callbacks(true);`