[PGPRO-4074] add suppress_internal_consistency_checks

danolivo · arssher · commit fb7d8999e318 · 2021-02-28T17:14:12.000+03:00
(cherry picked from commit fd57355d2d036c0f03c3800d6ebf03601454793b)

tags: multimaster
(cherry picked from commit 17687da6bed053574913f3ef34d39b415e728f51)
diff --git a/src/backend/utils/adt/domains.c b/src/backend/utils/adt/domains.c
@@ -61,6 +61,16 @@ typedef struct DomainIOData
 } DomainIOData;
 
 
+/*
+ * In the case of logical replication we can update a tuple. Master sends an old
+ * and a new version of the tuple. If we use contraint with "NOT VALID" clause
+ * then old version of the tuple can violate the constraint but new version can
+ * satisfy the constraint condition. In this case we need to suppress constraint
+ * checking during restoring tuple from network connection.
+ */
+bool suppress_internal_consistency_checks = false;
+
+
 /*
  * domain_state_setup - initialize the cache for a new domain type.
  *
@@ -133,6 +143,9 @@ domain_check_input(Datum value, bool isnull, DomainIOData *my_extra)
 	ExprContext *econtext = my_extra->econtext;
 	ListCell   *l;
 
+	if (suppress_internal_consistency_checks)
+		return;
+
 	/* Make sure we have up-to-date constraints */
 	UpdateDomainConstraintRef(&my_extra->constraint_ref);
 
diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
@@ -553,6 +553,9 @@ record_recv(PG_FUNCTION_ARGS)
 
 		/* Verify column datatype */
 		coltypoid = pq_getmsgint(buf, sizeof(Oid));
+		if (suppress_internal_consistency_checks)
+			coltypoid = column_type;
+
 		if (coltypoid != column_type)
 			ereport(ERROR,
 					(errcode(ERRCODE_DATATYPE_MISMATCH),
diff --git a/src/include/utils/builtins.h b/src/include/utils/builtins.h
@@ -26,6 +26,7 @@ extern bool parse_bool(const char *value, bool *result);
 extern bool parse_bool_with_len(const char *value, size_t len, bool *result);
 
 /* domains.c */
+extern bool suppress_internal_consistency_checks;
 extern void domain_check(Datum value, bool isnull, Oid domainType,
 						 void **extra, MemoryContext mcxt);
 extern int	errdatatype(Oid datatypeOid);
