do not use recursion in Cover() - ~2% performance

feodor · feodor · commit ff4b5c563a88 · 2016-09-13T15:54:06.000+03:00
diff --git a/rum_ts_utils.c b/rum_ts_utils.c
@@ -656,15 +656,13 @@ Cover(DocRepresentation *doc, uint32 len, QueryRepresentation *qr,
 	  Extention *ext)
 {
 	DocRepresentation *ptr;
-	int			lastpos = ext->pos;
+	int			lastpos;
 	int			i;
-	bool		found = false;
+	bool		found;
 
-	/*
-	 * since this function recurses, it could be driven to stack overflow.
-	 * (though any decent compiler will optimize away the tail-recursion.
-	 */
-	check_stack_depth();
+restart:
+	lastpos = ext->pos;
+	found = false;
 
 	memset(qr->operandexist, 0, sizeof(bool) * qr->lenght);
 
@@ -742,7 +740,7 @@ Cover(DocRepresentation *doc, uint32 len, QueryRepresentation *qr,
 	}
 
 	ext->pos++;
-	return Cover(doc, len, qr, ext);
+	goto restart;
 }
 
 static DocRepresentation *
