Fix mdtruncate() to close fd.c handle of deleted segments.

anarazel · anarazel · commit 26ce63ce76f9 · 2016-09-08T16:52:13.000-07:00
mdtruncate() forgot to FileClose() a segment's mdfd_vfd, when deleting it. That lead to a fd.c handle to a truncated file being kept open until backend exit. The issue appears to have been introduced way back in 1a5c450, before that the handle was closed inside FileUnlink(). The impact of this bug is limited - only VACUUM and ON COMMIT TRUNCATE for temporary tables, truncate files in place (i.e. TRUNCATE itself is not affected), and the relation has to be bigger than 1GB. The consequences of a leaked fd.c handle aren't severe either. Discussion: <20160908220748.oqh37ukwqqncbl3n@alap3.anarazel.de> Backpatch: all supported releases
diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
@@ -918,6 +918,7 @@ mdtruncate(SMgrRelation reln, ForkNumber forknum, BlockNumber nblocks)
 			v = v->mdfd_chain;
 			Assert(ov != reln->md_fd[forknum]); /* we never drop the 1st
 												 * segment */
+			FileClose(ov->mdfd_vfd);
 			pfree(ov);
 		}
 		else if (priorblocks + ((BlockNumber) RELSEG_SIZE) > nblocks)

Original file line number	Diff line number	Diff line change
`@@ -918,6 +918,7 @@ mdtruncate(SMgrRelation reln, ForkNumber forknum, BlockNumber nblocks)`
`918`	`918`	`v = v->mdfd_chain;`
`919`	`919`	`Assert(ov != reln->md_fd[forknum]); /* we never drop the 1st`
`920`	`920`	`* segment */`
	`921`	`+ FileClose(ov->mdfd_vfd);`
`921`	`922`	`pfree(ov);`
`922`	`923`	`}`
`923`	`924`	`else if (priorblocks + ((BlockNumber) RELSEG_SIZE) > nblocks)`