Consistently set all fields in pg_stat_replication to null instead of 0

mhagander · mhagander · commit 28c366789e78 · 2015-12-13T16:54:39.000+01:00
Previously the "sent" field would be set to 0 and all other xlog
pointers be set to NULL if there were no valid values (such as when
in a backup sending walsender).
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -2826,6 +2826,9 @@ pg_stat_get_wal_senders(PG_FUNCTION_ARGS)
 		else
 		{
 			values[1] = CStringGetTextDatum(WalSndGetStateString(state));
+
+			if (XLogRecPtrIsInvalid(sentPtr))
+				nulls[2] = true;
 			values[2] = LSNGetDatum(sentPtr);
 
 			if (XLogRecPtrIsInvalid(write))

Original file line number	Diff line number	Diff line change
`@@ -2826,6 +2826,9 @@ pg_stat_get_wal_senders(PG_FUNCTION_ARGS)`
`2826`	`2826`	`else`
`2827`	`2827`	`{`
`2828`	`2828`	`values[1] = CStringGetTextDatum(WalSndGetStateString(state));`
	`2829`	`+`
	`2830`	`+ if (XLogRecPtrIsInvalid(sentPtr))`
	`2831`	`+ nulls[2] = true;`
`2829`	`2832`	`values[2] = LSNGetDatum(sentPtr);`
`2830`	`2833`
`2831`	`2834`	`if (XLogRecPtrIsInvalid(write))`