Changes made by Hiroshi Inoue and approved by Vadim.

tatsuo-ishii · tatsuo-ishii · commit 2d0eee32c4af · 1999-09-16T09:08:56.000Z
See attached mail for more details.

-------------------------------------------------------------------
From: "Vadim Mikheev" &lt;vadim@krs.ru&gt;
To: "Hiroshi Inoue" &lt;Inoue@tpf.co.jp&gt;
References: &lt;000201befa94$42fe04c0$2801007e@cadzone.tpf.co.jp&gt;
Subject: Re: elog(ERROR) in vacuum
Date: Fri, 10 Sep 1999 10:27:10 +0900
Organization: OJSC Rostelecom (Krasnoyarsk)
Message-ID: &lt;37D85E6E.5AFA126D@krs.ru&gt;

Hiroshi Inoue wrote:
&gt;
&gt; Hello Vadim,
&gt;
&gt; I have a question about vacuum.
&gt;
&gt; VACUUM has a phase like commit which calls TransactionIdCommit().
&gt; But if elog(ERROR) occured after that,the status of transaction is
&gt; changed from XID_COMMIT to XID_ABORT.
&gt;
&gt; Seems to me this causes inconsistency.
&gt; Shoudn't AbortTransaction() be changed not to call TransacionIdAbort()
&gt; in case of vacuum.

You're right!
As usual -:)

Vadim
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.51 1999/09/09 16:25:35 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.52 1999/09/16 09:08:56 ishii Exp $
  *
  * NOTES
  *		Transaction aborts can now occur two ways:
@@ -736,7 +736,7 @@ RecordTransactionAbort()
 	 * this transaction id in the pg_log relation. We skip it
 	 * if no one shared buffer was changed by this transaction.
 	 */
-	if (SharedBufferChanged)
+	if (SharedBufferChanged && !TransactionIdDidCommit(xid))
 		TransactionIdAbort(xid);
 
 	ResetBufferPool();

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.51 1999/09/09 16:25:35 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.52 1999/09/16 09:08:56 ishii Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES`
`13`	`13`	`* Transaction aborts can now occur two ways:`
`@@ -736,7 +736,7 @@ RecordTransactionAbort()`
`736`	`736`	`* this transaction id in the pg_log relation. We skip it`
`737`	`737`	`* if no one shared buffer was changed by this transaction.`
`738`	`738`	`*/`
`739`		`- if (SharedBufferChanged)`
	`739`	`+ if (SharedBufferChanged && !TransactionIdDidCommit(xid))`
`740`	`740`	`TransactionIdAbort(xid);`
`741`	`741`
`742`	`742`	`ResetBufferPool();`