pathman: warnings fix, documentation

zilder · zilder · commit 5425c0f18532 · 2016-01-26T14:05:05.000+03:00
diff --git a/contrib/pg_pathman/README.md b/contrib/pg_pathman/README.md
@@ -37,8 +37,7 @@ Based on partitioning type and operator the `pg_pathman` searches corresponding
 
 To install pg_pathman run in psql:
 ```
-CREATE SCHEMA pathman;
-CREATE EXTENSION pg_pathman SCHEMA pathman;
+CREATE EXTENSION pg_pathman;
 ```
 Then modify shared_preload_libraries parameter in postgres.conf as following:
 ```
@@ -121,7 +120,7 @@ CREATE TABLE hash_rel (
     value   INTEGER);
 INSERT INTO hash_rel (value) SELECT g FROM generate_series(1, 10000) as g;
 ```
-Then run create_hash_partitions() function with appropriate arguments:
+If partitions are supposed to have indexes, then they should be created for parent table before partitioning. In this case pg_pathman will automaticaly create indexes for partitions. Then run create_hash_partitions() function with appropriate arguments:
 ```
 SELECT create_hash_partitions('hash_rel', 'value', 100);
 ```
diff --git a/contrib/pg_pathman/README.rus.md b/contrib/pg_pathman/README.rus.md
@@ -38,8 +38,7 @@ WHERE id = 150
 
 Для установки pg_pathman выполните в командной строке:
 ```
-CREATE SCHEMA pathman;
-CREATE EXTENSION pg_pathman SCHEMA pathman;
+CREATE EXTENSION pg_pathman;
 
 ```
 Затем модифицируйте параметр shared_preload_libraries в конфигурационном файле postgres.conf:
@@ -123,7 +122,7 @@ CREATE TABLE hash_rel (
     value   INTEGER);
 INSERT INTO hash_rel (value) SELECT g FROM generate_series(1, 10000) as g;
 ```
-Разобьем таблицу `hash_rel` на 100 секций по полю `value`:
+Если дочерние секции подразумевают наличие индексов, то стоит их создать в родительской таблице до разбиения. Тогда при разбиении pg_pathman автоматически создаст соответствующие индексы в дочерних.таблицах. Разобьем таблицу `hash_rel` на 100 секций по полю `value`:
 ```
 SELECT create_hash_partitions('hash_rel', 'value', 100);
 ```
diff --git a/contrib/pg_pathman/init.c b/contrib/pg_pathman/init.c
@@ -208,7 +208,7 @@ load_check_constraints(Oid parent_oid)
 	{
 		SPITupleTable *tuptable = SPI_tuptable;
 		Oid *children;
-		RangeEntry *ranges;
+		RangeEntry *ranges = NULL;
 		Datum min;
 		Datum max;
 		int hash;
diff --git a/contrib/pg_pathman/pg_pathman.c b/contrib/pg_pathman/pg_pathman.c
@@ -644,9 +644,9 @@ handle_binary_opexpr(const PartRelationInfo *prel, WrapperNode *result,
 			if (rangerel != NULL)
 			{
 				RangeEntry *re;
-				bool		found = false,
-							lossy = false;
+				bool		lossy = false;
 #ifdef USE_ASSERT_CHECKING
+				bool		found = false;
 				int			counter = 0;
 #endif
 				int			startidx = 0,
@@ -718,7 +718,9 @@ handle_binary_opexpr(const PartRelationInfo *prel, WrapperNode *result,
 							lossy = false;
 						else
 							lossy = true;
+#ifdef USE_ASSERT_CHECKING
 						found = true;
+#endif
 						break;
 					}
 
@@ -808,8 +810,10 @@ range_binary_search(const RangeRelation *rangerel, FmgrInfo *cmp_func, Datum val
 				cmp_max,
 				i = 0,
 				startidx = 0,
-				endidx = rangerel->ranges.length-1,
-				counter = 0;
+				endidx = rangerel->ranges.length-1;
+#ifdef USE_ASSERT_CHECKING
+	int			counter = 0;
+#endif
 
 	*foundPtr = false;
 
diff --git a/contrib/pg_pathman/rangeset.c b/contrib/pg_pathman/rangeset.c
@@ -52,7 +52,7 @@ irange_list_union(List *a, List *b)
 
 	while (ca || cb)
 	{
-		IndexRange	next;
+		IndexRange	next = 0;
 
 		/* Fetch next range with lesser lower bound */
 		if (ca && cb)

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ load_check_constraints(Oid parent_oid)`
`208`	`208`	`{`
`209`	`209`	`SPITupleTable *tuptable = SPI_tuptable;`
`210`	`210`	`Oid *children;`
`211`		`- RangeEntry *ranges;`
	`211`	`+ RangeEntry *ranges = NULL;`
`212`	`212`	`Datum min;`
`213`	`213`	`Datum max;`
`214`	`214`	`int hash;`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ irange_list_union(List a, List b)`
`52`	`52`
`53`	`53`	`while (ca \|\| cb)`
`54`	`54`	`{`
`55`		`- IndexRange next;`
	`55`	`+ IndexRange next = 0;`
`56`	`56`
`57`	`57`	`/* Fetch next range with lesser lower bound */`
`58`	`58`	`if (ca && cb)`