pathman: warnings fix

zilder · zilder · commit b22ac49fadaa · 2016-01-26T14:09:02.000+03:00
diff --git a/README.md b/README.md
@@ -123,7 +123,7 @@ CREATE TABLE hash_rel (
     value   INTEGER);
 INSERT INTO hash_rel (value) SELECT g FROM generate_series(1, 10000) as g;
 ```
-Then run create_hash_partitions() function with appropriate arguments:
+If partitions are supposed to have indexes, then they should be created for parent table before partitioning. In this case pg_pathman will automaticaly create indexes for partitions. Then run create_hash_partitions() function with appropriate arguments:
 ```
 SELECT create_hash_partitions('hash_rel', 'value', 100);
 ```
diff --git a/README.rus.md b/README.rus.md
@@ -124,7 +124,7 @@ CREATE TABLE hash_rel (
     value   INTEGER);
 INSERT INTO hash_rel (value) SELECT g FROM generate_series(1, 10000) as g;
 ```
-Разобьем таблицу `hash_rel` на 100 секций по полю `value`:
+Если дочерние секции подразумевают наличие индексов, то стоит их создать в родительской таблице до разбиения. Тогда при разбиении pg_pathman автоматически создаст соответствующие индексы в дочерних.таблицах. Разобьем таблицу `hash_rel` на 100 секций по полю `value`:
 ```
 SELECT create_hash_partitions('hash_rel', 'value', 100);
 ```
diff --git a/pg_pathman.c b/pg_pathman.c
@@ -644,9 +644,9 @@ handle_binary_opexpr(const PartRelationInfo *prel, WrapperNode *result,
 			if (rangerel != NULL)
 			{
 				RangeEntry *re;
-				bool		found = false,
-							lossy = false;
+				bool		lossy = false;
 #ifdef USE_ASSERT_CHECKING
+				bool		found = false;
 				int			counter = 0;
 #endif
 				int			startidx = 0,
@@ -718,7 +718,9 @@ handle_binary_opexpr(const PartRelationInfo *prel, WrapperNode *result,
 							lossy = false;
 						else
 							lossy = true;
+#ifdef USE_ASSERT_CHECKING
 						found = true;
+#endif
 						break;
 					}
 
diff --git a/rangeset.c b/rangeset.c
@@ -52,7 +52,7 @@ irange_list_union(List *a, List *b)
 
 	while (ca || cb)
 	{
-		IndexRange	next;
+		IndexRange	next = 0;
 
 		/* Fetch next range with lesser lower bound */
 		if (ca && cb)

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ irange_list_union(List a, List b)`
`52`	`52`
`53`	`53`	`while (ca \|\| cb)`
`54`	`54`	`{`
`55`		`- IndexRange next;`
	`55`	`+ IndexRange next = 0;`
`56`	`56`
`57`	`57`	`/* Fetch next range with lesser lower bound */`
`58`	`58`	`if (ca && cb)`