Correct statement to actually be the intended assert statement.

anarazel · anarazel · commit cb89644bb0df · 2015-12-14T11:25:04.000+01:00
e3f4cfc introduced a LWLockHeldByMe() call, without the corresponding Assert() surrounding it. Spotted by Coverity. Backpatch: 9.1+, like the previous commit
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -2943,7 +2943,7 @@ FlushOneBuffer(Buffer buffer)
 
 	bufHdr = GetBufferDescriptor(buffer - 1);
 
-	LWLockHeldByMe(bufHdr->content_lock);
+	Assert(LWLockHeldByMe(bufHdr->content_lock));
 
 	FlushBuffer(bufHdr, NULL);
 }

Original file line number	Diff line number	Diff line change
`@@ -2943,7 +2943,7 @@ FlushOneBuffer(Buffer buffer)`
`2943`	`2943`
`2944`	`2944`	`bufHdr = GetBufferDescriptor(buffer - 1);`
`2945`	`2945`
`2946`		`- LWLockHeldByMe(bufHdr->content_lock);`
	`2946`	`+ Assert(LWLockHeldByMe(bufHdr->content_lock));`
`2947`	`2947`
`2948`	`2948`	`FlushBuffer(bufHdr, NULL);`
`2949`	`2949`	`}`